Skip to content

Commit 13a0102

Browse files
committed
Categorize some MiMaFilters
1 parent 89f87fc commit 13a0102

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

project/MiMaFilters.scala

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ object MiMaFilters {
188188
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.*$extension"),
189189
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.*$extension"),
190190

191-
// Companion module class: Missing types {java.io.Serializable}
191+
// Companion module class: Missing type java.io.Serializable
192192
ProblemFilters.exclude[MissingTypesProblem]("scala.*$"),
193193

194-
// Non-categorized
195-
//
196-
// Many of the failures are related to missing static fields and methods in objects.
194+
// abstract method elemTag()scala.reflect.ClassTag in class scala.collection.mutable.ArraySeq does not have a correspondent in other version
197195
ProblemFilters.exclude[DirectAbstractMethodProblem]("scala.collection.immutable.ArraySeq.elemTag"),
198196
ProblemFilters.exclude[DirectAbstractMethodProblem]("scala.collection.mutable.ArraySeq.elemTag"),
197+
198+
// Non-categorized
199199
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.<:<.antisymm"),
200200
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.<:<.refl"),
201201
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.BitSet.ordMsg"),
@@ -329,7 +329,11 @@ object MiMaFilters {
329329
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.Properties.versionFor"),
330330
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.Right._1"),
331331
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.Success._1"),
332+
333+
// Non-categorized
332334
ProblemFilters.exclude[IncompatibleMethTypeProblem]("scala.collection.mutable.ArrayBuilder#ofUnit.addAll"),
335+
336+
// Non-categorized
333337
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.convert.JavaCollectionWrappers#JConcurrentMapWrapper.empty"),
334338
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.convert.JavaCollectionWrappers#JMapWrapper.empty"),
335339
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.collection.convert.JavaCollectionWrappers#JPropertiesWrapper.empty"),
@@ -340,6 +344,8 @@ object MiMaFilters {
340344
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.ManifestFactory#NothingManifest.newArray"),
341345
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.reflect.ManifestFactory#NullManifest.newArray"),
342346
ProblemFilters.exclude[IncompatibleResultTypeProblem]("scala.StringContext.unapplySeq"),
347+
348+
// static field ... in object ... does not have a correspondent in other version
343349
ProblemFilters.exclude[MissingFieldProblem]("scala.Array.UnapplySeqWrapper"),
344350
ProblemFilters.exclude[MissingFieldProblem]("scala.collection.concurrent.TrieMap.RemovalPolicy"),
345351
ProblemFilters.exclude[MissingFieldProblem]("scala.collection.convert.StreamExtensions.AccumulatorFactoryInfo"),
@@ -491,7 +497,11 @@ object MiMaFilters {
491497
ProblemFilters.exclude[MissingFieldProblem]("scala.util.Using.Manager"),
492498
ProblemFilters.exclude[MissingFieldProblem]("scala.util.Using.Releasable"),
493499
ProblemFilters.exclude[MissingFieldProblem]("scala.util.Using#Releasable.AutoCloseableIsReleasable"),
500+
501+
// the type hierarchy of class scala.Array is different in other version. Missing types {java.io.Serializable,java.lang.Cloneable}
494502
ProblemFilters.exclude[MissingTypesProblem]("scala.Array"),
503+
504+
// abstract method coll()scala.collection.immutable.SortedMapOps in interface scala.collection.immutable.SortedMapOps is present only in other version
495505
ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.collection.immutable.SortedMapOps.coll"),
496506
)
497507
)

0 commit comments

Comments
 (0)