add more tasty forward compat tests

Author: bishabosha

compiler/src/dotty/tools/dotc/config/ScalaSettings.scala

@@ -155,6 +155,7 @@ class ScalaSettings extends Settings.SettingGroup with CommonScalaSettings {
   val Yhelp: Setting[Boolean] = BooleanSetting("-Y", "Print a synopsis of private options.")
   val Ycheck: Setting[List[String]] = PhasesSetting("-Ycheck", "Check the tree at the end of")
   val YcheckMods: Setting[Boolean] = BooleanSetting("-Ycheck-mods", "Check that symbols and their defining trees have modifiers in sync.")
+  val YstrictTasty: Setting[Boolean] = BooleanSetting("-Ystrict-tasty", "Increase strictness of TASTy unpickler when resolving symbols in other compilation units.")
   val Ydebug: Setting[Boolean] = BooleanSetting("-Ydebug", "Increase the quantity of debugging output.")
   val YdebugTrace: Setting[Boolean] = BooleanSetting("-Ydebug-trace", "Trace core operations.")
   val YdebugFlags: Setting[Boolean] = BooleanSetting("-Ydebug-flags", "Print all flags of definitions.")

compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala

@@ -1195,8 +1195,12 @@ class TreeUnpickler(reader: TastyReader,
                 && sym.targetName == target
                 && sym.signature == sig
               val denot = qualType.findMember(name, prefix).filterWithPredicate(matchOverload)
-              // TODO: if denot == NoDenotation then ???
-              makeSelect(qual, name, denot)
+              val select = makeSelect(qual, name, denot)
+              if !denot.exists && ctx.settings.YstrictTasty.value then
+                typer.ErrorReporting.errorTree(select,
+                  i"While unpickling, I was looking in (${qual.denot}: ${qual.tpe}) but could not find method $name (defined in ${owner.showLocated}, ${sname.info})")
+              else
+                select
             case REPEATED =>
               val elemtpt = readTpt()
               SeqLiteral(until(end)(readTerm()), elemtpt)

sbt-dotty/sbt-test/source-dependencies/tasty-add-overload/a-changes/A.scala

@@ -2,15 +2,9 @@ package a
 
 object A {
 
-  trait Box0[A] {
+  class Buf[A] {
     def append(a: A): this.type = this
-    def append(a: String): Unit = ()
+    def append(a: A*): this.type = this
   }
 
-  trait BoxInt extends Box0[Int] {
-    override def append(a: Int): this.type = this
-  }
-
-  val box: BoxInt = new BoxInt {}
-
 }

sbt-dotty/sbt-test/source-dependencies/tasty-add-overload/a/A.scala

@@ -2,13 +2,8 @@ package a
 
 object A {
 
-  trait Box0[A] {
+  class Buf[A] {
     def append(a: A): this.type = this
-    def append(a: String): Unit = ()
   }
 
-  trait BoxInt extends Box0[Int]
-
-  val box: BoxInt = new BoxInt {}
-
 }

sbt-dotty/sbt-test/source-dependencies/tasty-add-overload/b/B.scala

@@ -1,5 +1,7 @@
 import a.*
 
-object B extends App {
-  A.box.append(0)
+object B {
+  val foo = new A.Buf[Seq[Double]]
+  val bar = Seq.empty[Double]
+  foo.append(bar)
 }

sbt-dotty/sbt-test/source-dependencies/tasty-add-overload/build.sbt

@@ -14,9 +14,9 @@ lazy val `a-changes` = project.in(file("a-changes"))
     Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
   )
 
-lazy val c = project.in(file("c"))
+lazy val c = project.in(file("."))
   .settings(
-    scalacOptions ++= Seq("-from-tasty"),
+    scalacOptions ++= Seq("-from-tasty", "-Ystrict-tasty", "-Ycheck:readTasty"),
     Compile / sources := Seq(new java.io.File("c-input/B.tasty")),
     Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "c-input",
     Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-output"

sbt-dotty/sbt-test/source-dependencies/tasty-add-overload/test

@@ -1,4 +1,8 @@
+# compile library A
 > a/compile
+# compile library B, from source, against A
 > b/compile
+# add a new overload to library A'
 > a-changes/compile
+# compile B, from tasty, against A', it should still compile: the overload does not conflict
 > c/compile

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/a-changes/A.scala

@@ -0,0 +1,15 @@
+package a
+
+object A {
+
+  trait Box0[A] {
+    def append(a: A): this.type = this
+  }
+
+  trait BoxInt extends Box0[Int] {
+    override def append(a: Int): this.type = this
+  }
+
+  val box: BoxInt = new BoxInt {}
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/a/A.scala

@@ -0,0 +1,13 @@
+package a
+
+object A {
+
+  trait Box0[A] {
+    def append(a: A): this.type = this
+  }
+
+  trait BoxInt extends Box0[Int]
+
+  val box: BoxInt = new BoxInt {}
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/b/B.scala

@@ -0,0 +1,5 @@
+import a.*
+
+object B extends App {
+  A.box.append(0)
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/build.sbt

@@ -0,0 +1,23 @@
+lazy val a = project.in(file("a"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "b-input"
+  )
+
+lazy val b = project.in(file("b"))
+  .settings(
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "b-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val `a-changes` = project.in(file("a-changes"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val c = project.in(file("."))
+  .settings(
+    scalacOptions ++= Seq("-from-tasty", "-Ystrict-tasty", "-Ycheck:readTasty"),
+    Compile / sources := Seq(new java.io.File("c-input/B.tasty")),
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "c-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-output"
+  )

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/project/DottyInjectedPlugin.scala

@@ -0,0 +1,11 @@
+import sbt._
+import Keys._
+
+object DottyInjectedPlugin extends AutoPlugin {
+  override def requires = plugins.JvmPlugin
+  override def trigger = allRequirements
+
+  override val projectSettings = Seq(
+    scalaVersion := sys.props("plugin.scalaVersion")
+  )
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % sys.props("plugin.version"))

sbt-dotty/sbt-test/source-dependencies/tasty-add-override/test

@@ -0,0 +1,8 @@
+# compile library A
+> a/compile
+# compile library B, from source, against A
+> b/compile
+# add a new override to library A'
+> a-changes/compile
+# compile B, from tasty, against A', it should still compile: the override is forward compatible
+> c/compile

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/a-changes/A.scala

@@ -0,0 +1,11 @@
+package a
+
+object A {
+
+  trait Fn[-T1, +R] { def apply(v1: T1): R }
+
+  val fn0: Fn[Int, Int] { def apply(arg: Int): Int } = x => x
+
+  val fn = fn0
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/a/A.scala

@@ -0,0 +1,11 @@
+package a
+
+object A {
+
+  trait Fn[-T1, +R] { def apply(v1: T1): R }
+
+  val fn0: Fn[Int, Int] = x => x
+
+  val fn = fn0
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/b/B.scala

@@ -0,0 +1,5 @@
+import a.*
+
+object B extends App {
+  A.fn(v1 = 0)
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/build.sbt

@@ -0,0 +1,23 @@
+lazy val a = project.in(file("a"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "b-input"
+  )
+
+lazy val b = project.in(file("b"))
+  .settings(
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "b-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val `a-changes` = project.in(file("a-changes"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val c = project.in(file("."))
+  .settings(
+    scalacOptions ++= Seq("-from-tasty", "-Ystrict-tasty", "-Ycheck:readTasty"),
+    Compile / sources := Seq(new java.io.File("c-input/B.tasty")),
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "c-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-output"
+  )

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/project/DottyInjectedPlugin.scala

@@ -0,0 +1,11 @@
+import sbt._
+import Keys._
+
+object DottyInjectedPlugin extends AutoPlugin {
+  override def requires = plugins.JvmPlugin
+  override def trigger = allRequirements
+
+  override val projectSettings = Seq(
+    scalaVersion := sys.props("plugin.scalaVersion")
+  )
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % sys.props("plugin.version"))

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement-incompat/test

@@ -0,0 +1,9 @@
+# compile library A
+> a/compile
+# compile library B, from source, against A
+> b/compile
+# add a refinement in library A'
+> a-changes/compile
+# compile B, from tasty, against A', it should fail to compile: the refinement of `Fn.apply` has changed its
+# named arguments.
+-> c/compile

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/a-changes/A.scala

@@ -0,0 +1,12 @@
+package a
+
+object A {
+
+  trait Box[A] {
+    def append(a: A): Unit = ()
+  }
+
+  val box: Box[Int] { def append(a: Int): Unit } =
+    new Box[Int] { override def append(a: Int): Unit = () }
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/a/A.scala

@@ -0,0 +1,12 @@
+package a
+
+object A {
+
+  trait Box[A] {
+    def append(a: A): Unit = ()
+  }
+
+  val box: Box[Int] =
+    new Box[Int] {}
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/b/B.scala

@@ -0,0 +1,5 @@
+import a.*
+
+object B extends App {
+  A.box.append(a = 0)
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/build.sbt

@@ -0,0 +1,23 @@
+lazy val a = project.in(file("a"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "b-input"
+  )
+
+lazy val b = project.in(file("b"))
+  .settings(
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "b-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val `a-changes` = project.in(file("a-changes"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val c = project.in(file("."))
+  .settings(
+    scalacOptions ++= Seq("-from-tasty", "-Ystrict-tasty", "-Ycheck:readTasty"),
+    Compile / sources := Seq(new java.io.File("c-input/B.tasty")),
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "c-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-output"
+  )

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/project/DottyInjectedPlugin.scala

@@ -0,0 +1,11 @@
+import sbt._
+import Keys._
+
+object DottyInjectedPlugin extends AutoPlugin {
+  override def requires = plugins.JvmPlugin
+  override def trigger = allRequirements
+
+  override val projectSettings = Seq(
+    scalaVersion := sys.props("plugin.scalaVersion")
+  )
+}

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % sys.props("plugin.version"))

sbt-dotty/sbt-test/source-dependencies/tasty-add-refinement/test

@@ -0,0 +1,8 @@
+# compile library A
+> a/compile
+# compile library B, from source, against A
+> b/compile
+# add a new refinement to library A'
+> a-changes/compile
+# compile B, from tasty, against A', it should still compile: the refinement is forward compatible
+> c/compile

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/a-changes/A.scala

@@ -0,0 +1,11 @@
+package a
+
+object A {
+
+  trait Fn[-T1, +R] { def apply(v1: T1): R }
+
+  val fn0: Fn[Int, Int] { def apply(arg: Int): Int } = x => x
+
+  val fn = fn0
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/a/A.scala

@@ -0,0 +1,11 @@
+package a
+
+object A {
+
+  trait Fn[-T1, +R] { def apply(v1: T1): R }
+
+  val fn0: Fn[Int, Int] { def apply(int: Int): Int } = x => x
+
+  val fn = fn0
+
+}

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/b/B.scala

@@ -0,0 +1,5 @@
+import a.*
+
+object B extends App {
+  A.fn(int = 0)
+}

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/build.sbt

@@ -0,0 +1,23 @@
+lazy val a = project.in(file("a"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "b-input"
+  )
+
+lazy val b = project.in(file("b"))
+  .settings(
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "b-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val `a-changes` = project.in(file("a-changes"))
+  .settings(
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-input"
+  )
+
+lazy val c = project.in(file("."))
+  .settings(
+    scalacOptions ++= Seq("-from-tasty", "-Ystrict-tasty", "-Ycheck:readTasty"),
+    Compile / sources := Seq(new java.io.File("c-input/B.tasty")),
+    Compile / unmanagedClasspath += (ThisBuild / baseDirectory).value / "c-input",
+    Compile / classDirectory := (ThisBuild / baseDirectory).value / "c-output"
+  )

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/project/DottyInjectedPlugin.scala

@@ -0,0 +1,11 @@
+import sbt._
+import Keys._
+
+object DottyInjectedPlugin extends AutoPlugin {
+  override def requires = plugins.JvmPlugin
+  override def trigger = allRequirements
+
+  override val projectSettings = Seq(
+    scalaVersion := sys.props("plugin.scalaVersion")
+  )
+}

sbt-dotty/sbt-test/source-dependencies/tasty-change-refinement/project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % sys.props("plugin.version"))