wip 10

Author: bishabosha

compiler/src/dotty/tools/dotc/core/tasty/TastyPrinter.scala

@@ -90,9 +90,7 @@ class TastyPrinter(bytes: Array[Byte]) {
               printName(); printName()
             case VALDEF | DEFDEF | TYPEDEF | TYPEPARAM | PARAM | NAMEDARG | BIND =>
               printName(); printTrees()
-            case SELECTin =>
-              printName(); printName(); printTree(); printTrees()
-            case REFINEDtype | TERMREFin | TYPEREFin =>
+            case REFINEDtype | TERMREFin | TYPEREFin | SELECTin =>
               printName(); printTree(); printTrees()
             case RETURN | HOLE =>
               printNat(); printTrees()

compiler/src/dotty/tools/dotc/core/tasty/TreePickler.scala

@@ -417,7 +417,6 @@ class TreePickler(pickler: TastyPickler) {
                 writeByte(SELECTin)
                 withLength {
                   pickleNameAndSig(name, tree.symbol.signature, ename)
-                  pickleNameAndSig(name, sig, ename)
                   pickleTree(qual)
                   if tree.symbol.exists then // TODO: `1.unary_+` has no symbol
                     pickleType(tree.symbol.owner.typeRef)

compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala

@@ -1177,20 +1177,7 @@ class TreeUnpickler(reader: TastyReader,
               val levels = readNat()
               readTerm().outerSelect(levels, SkolemType(readType()))
             case SELECTin =>
-              // ================================================================================
-              // Test Report
-              // ================================================================================
-
-              // 3 suites passed, 1 failed, 4 total
-              //     ] failed
-              //     tests/pos/i5418.scala failed
-              //     tests/pos/i5980.scala failed
-              val srcnmes = Nil//List("i5980", "i5418")
-              val doinspect = srcnmes.exists(ctx.source.name.startsWith)
               var symname = readName()
-              var precisesig = readName() match
-                case SignedName(_, sig, _) => sig
-                case _ => Signature.NotAMethod
               val qual = readTerm()
               val qualType = qual.tpe.widenIfUnstable
               val space = if currentAddr == end then qualType else readType()
@@ -1211,23 +1198,15 @@ class TreeUnpickler(reader: TastyReader,
               val res = symname match
                 case SignedName(name, sig, target) =>
                   val pre = ctx.typeAssigner.maybeSkolemizePrefix(qualType, name)
-                  assert(precisesig != Signature.NotAMethod)
                   val isAmbiguous = pre.nonPrivateMember(name).match
                     case d: MultiDenotation =>
                       d.atSignature(sig, target).isInstanceOf[MultiDenotation]
                     case _ => false
                   if isAmbiguous then
-                    if doinspect then
-                      val diff = if sig != precisesig then i"$sig => $precisesig" else i"$sig"
-                      report.error(i"$qual . $name differs ambiguously: [$diff]")
                     makeSelect(qual, name, space.decl(name).atSignature(sig, target).asSeenFrom(pre))
                   else
-                    if doinspect && sig != precisesig then
-                      report.error(i"$qual . $name differs: [$sig => $precisesig]")
                     select(name, sig, target)
                 case name =>
-                  if doinspect then
-                    report.error(i"$qual . $name nosig")
                   makeSelect(qual, name, accessibleDenot(qualType, name, Signature.NotAMethod, EmptyTermName))
                   // select(name, Signature.NotAMethod, EmptyTermName)
               res

tasty/src/dotty/tools/tasty/TastyFormat.scala

@@ -709,8 +709,8 @@ object TastyFormat {
    */
   def numRefs(tag: Int): Int = tag match {
     case VALDEF | DEFDEF | TYPEDEF | TYPEPARAM | PARAM | NAMEDARG | RETURN | BIND |
-         SELFDEF | REFINEDtype | TERMREFin | TYPEREFin | HOLE => 1
-    case RENAMED | PARAMtype | SELECTin => 2
+         SELFDEF | REFINEDtype | TERMREFin | TYPEREFin | HOLE | SELECTin => 1
+    case RENAMED | PARAMtype => 2
     case POLYtype | TYPELAMBDAtype | METHODtype => -1
     case _ => 0
   }