Outline macro evaluation exception handling

Author: nicolasstucki

compiler/src/dotty/tools/dotc/transform/Splicer.scala

@@ -36,24 +36,31 @@ object Splicer {
       val liftedArgs = getLiftedArgs(call, bindings)
       val interpreter = new Interpreter(pos, classLoader)
       val interpreted = interpreter.interpretCallToSymbol[Seq[Any] => Object](call.symbol)
-      try {
+      evaluateMacro(pos) {
+        // Some parts of the macro are evaluated during the unpickling performed in quotedExprToTree
         val evaluated = interpreted.map(lambda => lambda(liftedArgs).asInstanceOf[scala.quoted.Expr[Nothing]])
         evaluated.fold(tree)(PickledQuotes.quotedExprToTree)
-      } catch {
-        case ex: scala.quoted.QuoteError =>
-          ctx.error(ex.getMessage, pos)
-          EmptyTree
-        case NonFatal(ex) =>
-          val msg =
-            s"""Failed to evaluate inlined quote.
-               |  Caused by ${ex.getClass}: ${if (ex.getMessage == null) "" else ex.getMessage}
-               |    ${ex.getStackTrace.takeWhile(_.getClassName != "dotty.tools.dotc.transform.Splicer$").init.mkString("\n    ")}
-         """.stripMargin
-          ctx.error(msg, pos)
-          EmptyTree
       }
   }
 
+  /* Evaluate the code in the macro and handle exceptions durring evaluation */
+  private def evaluateMacro(pos: Position)(code: => Tree)(implicit ctx: Context): Tree = {
+    try code
+    catch {
+      case ex: scala.quoted.QuoteError =>
+        ctx.error(ex.getMessage, pos)
+        EmptyTree
+      case NonFatal(ex) =>
+        val msg =
+          s"""Failed to evaluate inlined quote.
+             |  Caused by ${ex.getClass}: ${if (ex.getMessage == null) "" else ex.getMessage}
+             |    ${ex.getStackTrace.takeWhile(_.getClassName != "dotty.tools.dotc.transform.Splicer$").init.mkString("\n    ")}
+         """.stripMargin
+        ctx.error(msg, pos)
+        EmptyTree
+    }
+  }
+
   /** Given the inline code and bindings, compute the lifted arguments that will be used to execute the macro
    *  - Type parameters are lifted to quoted.Types.TreeType
    *  - Inline parameters are listed as their value