Fix missing positions

Author: nicolasstucki

compiler/src/dotty/tools/dotc/quoted/ExprFrontend.scala

@@ -34,18 +34,18 @@ class ExprFrontend(putInClass: Boolean) extends FrontEnd {
   }
 
   private def inClass(expr: Expr[_])(implicit ctx: Context): Tree = {
-    val coord: Coord = NoCoord // TODO add positions
+    val pos = Position(0)
     val assocFile = new PlainFile(Path("<quote>"))
 
     val cls = ctx.newCompleteClassSymbol(defn.RootClass, nme.QUOTE.toTypeName, EmptyFlags,
-        defn.ObjectType :: Nil, newScope, coord = coord, assocFile = assocFile).entered.asClass
+        defn.ObjectType :: Nil, newScope, coord = pos, assocFile = assocFile).entered.asClass
     cls.enter(ctx.newDefaultConstructor(cls), EmptyScope)
-    val meth = ctx.newSymbol(cls, nme.apply, Method, ExprType(defn.AnyType), coord = coord).entered
+    val meth = ctx.newSymbol(cls, nme.apply, Method, ExprType(defn.AnyType), coord = pos).entered
 
     val quoted = quotedToTree(expr)(ctx.withOwner(meth))
 
     val run = DefDef(meth, quoted)
     val classTree = ClassDef(cls, DefDef(cls.primaryConstructor.asTerm), run :: Nil)
-    PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], classTree :: Nil)
+    PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], classTree :: Nil).withPos(pos)
   }
 }

compiler/src/dotty/tools/dotc/quoted/PickledQuotes.scala

@@ -53,8 +53,8 @@ object PickledQuotes {
    */
   private def encapsulateQuote(tree: Tree)(implicit ctx: Context): Tree = {
     val sym = ctx.newSymbol(ctx.owner, "'".toTermName, Synthetic, defn.AnyType, coord = tree.pos)
-    val quotedVal = ValDef(sym, tree)
-    PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], quotedVal :: Nil)
+    val quotedVal = ValDef(sym, tree).withPos(tree.pos)
+    PackageDef(ref(defn.RootPackage).asInstanceOf[Ident], quotedVal :: Nil).withPos(tree.pos)
   }
 
   // TASTY picklingtests/pos/quoteTest.scala

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -58,9 +58,9 @@ object Typer {
   }
 
   /** Assert tree has a position, unless it is empty or a typed splice */
-  def assertPositioned(tree: untpd.Tree)(implicit ctx: Context) = ()
-//    if (!tree.isEmpty && !tree.isInstanceOf[untpd.TypedSplice] && ctx.typerState.isGlobalCommittable)
-//      assert(tree.pos.exists, s"position not set for $tree # ${tree.uniqueId}")
+  def assertPositioned(tree: untpd.Tree)(implicit ctx: Context) =
+    if (!tree.isEmpty && !tree.isInstanceOf[untpd.TypedSplice] && ctx.typerState.isGlobalCommittable)
+      assert(tree.pos.exists, s"position not set for $tree # ${tree.uniqueId}")
 
   private val ExprOwner = new Property.Key[Symbol]
   private val InsertedApply = new Property.Key[Unit]