Merge pull request #9035 from dotty-staging/make-NonEmptyTuple-Product

Make NonEmptyTuple a Product

Author: nicolasstucki

compiler/src/dotty/tools/dotc/typer/Applications.scala

@@ -116,7 +116,7 @@ object Applications {
       if (sel.exists) sel :: tupleSelectors(n + 1, tp) else Nil
     }
     def genTupleSelectors(n: Int, tp: Type): List[Type] = tp match {
-      case tp: AppliedType if !tp.derivesFrom(defn.ProductClass) && tp.derivesFrom(defn.PairClass) =>
+      case tp: AppliedType if !defn.isTupleClass(tp.typeSymbol) && tp.derivesFrom(defn.PairClass) =>
         val List(head, tail) = tp.args
         head :: genTupleSelectors(n, tail)
       case _ => tupleSelectors(n, tp)

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -1147,7 +1147,9 @@ class Typer extends Namer
 
     val desugared =
       if (protoFormals.length == 1 && params.length != 1 && ptIsCorrectProduct(protoFormals.head)) {
-        val isGenericTuple = !protoFormals.head.derivesFrom(defn.ProductClass)
+        val isGenericTuple =
+          protoFormals.head.derivesFrom(defn.TupleClass)
+          && !defn.isTupleClass(protoFormals.head.typeSymbol)
         desugar.makeTupledFunction(params, fnBody, isGenericTuple)
       }
       else {

library/src/scala/Tuple.scala

@@ -186,7 +186,7 @@ object Tuple {
 }
 
 /** Tuple of arbitrary non-zero arity */
-sealed trait NonEmptyTuple extends Tuple {
+sealed trait NonEmptyTuple extends Tuple with Product {
   import Tuple._
 
   /** Get the i-th element of this tuple.

tests/run/tuple-product.scala

@@ -0,0 +1,11 @@
+@main def Test = {
+  val a: Product = 1 *: ()
+  assert(a.productArity == 1)
+  val b: Product = 1 *: 2 *: ()
+  assert(b.productArity == 2)
+  val c: Product = 1 *: 2 *: 3 *: 4 *: 5 *: 6 *: 7 *: 8 *: 9 *: 10 *: 11 *: 12 *: 13 *: 14 *: 15 *: 16 *: 17 *: 18 *: 19 *: 20 *: 21 *: 22 *: 23 *: 24 *: 25 *: ()
+  assert(c.productArity == 25)
+  val d: NonEmptyTuple = (1, 2)
+  val e: Product = d
+  assert(e.productArity == 2)
+}