Remove dead code from ClassfileParser (#17595)

smarter · web-flow · commit b29740d331fb · 2023-05-26T16:21:12.000+02:00
diff --git a/compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala b/compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala
@@ -991,7 +991,9 @@ class ClassfileParser(
             return unpickleTASTY(tastyBytes)
           }
         }
-        else return unpickleTASTY(bytes)
+        else
+          // Before 3.0.0 we had a mode where we could embed the TASTY bytes in the classfile. This has not been supported in any stable release.
+          report.error(s"Found a TASTY attribute with a length different from 16 in $classfile. This is likely a bug in the compiler. Please report.", NoSourcePosition)
       }
 
       if scan(tpnme.ScalaATTR) && !scalaUnpickleWhitelist.contains(classRoot.name)

Original file line number	Diff line number	Diff line change
`@@ -991,7 +991,9 @@ class ClassfileParser(`
`991`	`991`	`return unpickleTASTY(tastyBytes)`
`992`	`992`	`}`
`993`	`993`	`}`
`994`		`- else return unpickleTASTY(bytes)`
	`994`	`+ else`
	`995`	`+ // Before 3.0.0 we had a mode where we could embed the TASTY bytes in the classfile. This has not been supported in any stable release.`
	`996`	`+ report.error(s"Found a TASTY attribute with a length different from 16 in $classfile. This is likely a bug in the compiler. Please report.", NoSourcePosition)`
`995`	`997`	`}`
`996`	`998`
`997`	`999`	`if scan(tpnme.ScalaATTR) && !scalaUnpickleWhitelist.contains(classRoot.name)`