Test for legitimate NoClassDefFoundError in Splicer

Author: nicolasstucki

compiler/src/dotty/tools/dotc/transform/Splicer.scala

@@ -372,8 +372,11 @@ object Splicer {
     private object MissingClassDefinedInCurrentRun {
       def unapply(targetException: NoClassDefFoundError)(given ctx: Context): Option[Symbol] = {
         val className = targetException.getMessage
-        val sym = ctx.base.staticRef(className.toTypeName).symbol
-        if (sym.isDefinedInCurrentRun) Some(sym) else None
+        if (className eq null) None
+        else {
+          val sym = ctx.base.staticRef(className.toTypeName).symbol
+          if (sym.isDefinedInCurrentRun) Some(sym) else None
+        }
       }
     }
 

tests/neg-macros/macro-class-not-found-1.check

@@ -0,0 +1,8 @@
+-- Error: tests/neg-macros/macro-class-not-found-1/Bar.scala:4:13 ------------------------------------------------------
+4 |  Foo.myMacro() // error
+  |  ^^^^^^^^^^^^^
+  |  Exception occurred while executing macro expansion.
+  |  java.lang.NoClassDefFoundError
+  |  	at Foo$.aMacroImplementation(Foo.scala:8)
+  |  
+  | This location is in code that was inlined at Bar.scala:4

tests/neg-macros/macro-class-not-found-1/Bar.scala

@@ -0,0 +1,5 @@
+import scala.quoted._
+
+object Bar {
+  Foo.myMacro() // error
+}

tests/neg-macros/macro-class-not-found-1/Foo.scala

@@ -0,0 +1,10 @@
+import scala.quoted._
+
+object Foo {
+
+  inline def myMacro(): Unit = ${ aMacroImplementation }
+
+  def aMacroImplementation(given QuoteContext): Expr[Unit] =
+    throw new NoClassDefFoundError()
+
+}

tests/neg-macros/macro-class-not-found-2.check

@@ -0,0 +1,8 @@
+-- Error: tests/neg-macros/macro-class-not-found-2/Bar.scala:4:13 ------------------------------------------------------
+4 |  Foo.myMacro() // error
+  |  ^^^^^^^^^^^^^
+  |  Exception occurred while executing macro expansion.
+  |  java.lang.NoClassDefFoundError: this.is.not.a.Class
+  |  	at Foo$.aMacroImplementation(Foo.scala:8)
+  |  
+  | This location is in code that was inlined at Bar.scala:4

tests/neg-macros/macro-class-not-found-2/Bar.scala

@@ -0,0 +1,5 @@
+import scala.quoted._
+
+object Bar {
+  Foo.myMacro() // error
+}

tests/neg-macros/macro-class-not-found-2/Foo.scala

@@ -0,0 +1,10 @@
+import scala.quoted._
+
+object Foo {
+
+  inline def myMacro(): Unit = ${ aMacroImplementation }
+
+  def aMacroImplementation(given QuoteContext): Expr[Unit] =
+    throw new NoClassDefFoundError("this.is.not.a.Class")
+
+}