Skip to content

Allow comments to be cooked from TASTy #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abgruszecki opened this issue Nov 2, 2020 · 3 comments
Closed

Allow comments to be cooked from TASTy #10147

abgruszecki opened this issue Nov 2, 2020 · 3 comments

Comments

@abgruszecki
Copy link
Contributor

In the doctool, we need to implement resolve Scaladoc comment variables (@define) - see https://docs.scala-lang.org/overviews/scaladoc/for-library-authors.html#macros for the only documentation I'm aware of.

Dottydoc resolved those under YcookComments flag, but the result of that was not serialised to TASTy. We anyway came to the conclusion that for design reasons, we want to avoid adding expanded comments to TASTy.

This means that we need to investigate whether the code responsible for "cooking" comments could also be ran when classes are loaded from TASTy.

@abgruszecki
Copy link
Contributor Author

@bishabosha I gave the problem some thought and I believe the best time to get started on this would be after #10143 is fixed, since stdlib is the best test case for this issue.

@bishabosha
Copy link
Member

bishabosha commented Nov 2, 2020

@abgruszecki ok thanks, I'll take a look at that point

@abgruszecki
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants