Skip to content

Please merge in latest ProtoQuill into community build #12625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deusaquilus opened this issue May 27, 2021 · 7 comments
Closed

Please merge in latest ProtoQuill into community build #12625

deusaquilus opened this issue May 27, 2021 · 7 comments

Comments

@deusaquilus
Copy link
Contributor

Hi, I made a PR to merge in latest ProtoQuill into the community build here:
dotty-staging/protoquill#1

Could someone please merge this?
Sorry if this is the wrong place for requests like this. How should I do it in the future?

@smarter
Copy link
Member

smarter commented May 27, 2021

I've given you push access to that repo, so you can just push there then open a PR here to update the submodule commit. Just make sure to never push-force and overwrite existing commits since that would prevent existing commits from passing the CI.

@deusaquilus
Copy link
Contributor Author

Okay. Thanks!
Should I open up the submodule commit against dotty or dotty-staging?

@smarter
Copy link
Member

smarter commented May 27, 2021

against this repo, lampepfl/dotty

@deusaquilus
Copy link
Contributor Author

Okay, just opened. #12630
Thanks!

@deusaquilus
Copy link
Contributor Author

@smarter Any chance you can approve my workflow in #12630 ?

@deusaquilus
Copy link
Contributor Author

Working now. Thanks!

@deusaquilus
Copy link
Contributor Author

@smarter I restarted the builds. Looks like I need approval again. Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants