Skip to content

Scaladoc: Implement "Run" logic in snippets #13065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pikinier20 opened this issue Jul 13, 2021 · 2 comments · Fixed by #13258
Closed

Scaladoc: Implement "Run" logic in snippets #13065

pikinier20 opened this issue Jul 13, 2021 · 2 comments · Fixed by #13258
Assignees
@pikinier20
Labels
area:doctool itype:enhancement
Milestone
3.1.0

Comments

@pikinier20
Copy link
Contributor

Recent changes to snippet prepare "Run" button in Scala snippets. We can discuss how and when should we allow user to run snippet (maybe via Scastie?)
@pikinier20 pikinier20 self-assigned this Jul 13, 2021
@pikinier20 pikinier20 mentioned this issue Aug 24, 2021
Merged
@pikinier20 pikinier20 linked a pull request Aug 27, 2021 that will close this issue
Scaladoc: Integrate Scastie into Scaladoc #13258
Merged
@deusaquilus
Copy link
Contributor

Hey @pikinier20. I don't see the "Run" button in the Dotty docs anymore. Was this feature removed recently?

@pikinier20
Copy link
Contributor Author

Hey, it's not removed. We've just restricted the logic: Now the snippet can only be ran if it's checked by a snippet compiler. (It prevents non-sensical snippets from being ran)

@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pikinier20 pikinier20

Labels
area:doctool itype:enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Scaladoc: Integrate Scastie into Scaladoc pikinier20/dotty
3 participants
@deusaquilus @Kordyjan @pikinier20