Skip to content

Regression in dfianthdl/dfiant - for implicit resolution #18495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WojciechMazur opened this issue Aug 31, 2023 · 1 comment
Closed

Regression in dfianthdl/dfiant - for implicit resolution #18495

WojciechMazur opened this issue Aug 31, 2023 · 1 comment
Labels
area:implicits related to implicits itype:bug regression This worked in a previous version but doesn't anymore stat:duplicate stat:needs minimization Needs a self contained minimization

Comments

@WojciechMazur
Copy link
Contributor

WojciechMazur commented Aug 31, 2023

Compiler version

3.3.1-RC7
Works in 3.3.0

Bisect points to ded5d25

Minimized code

Not yet minimized:

//> using lib "io.github.dfianthdl::dfhdl-compiler-stages:0.3.4"
import dfhdl.*
import dfhdl.internals.TopLevel
@main def Test() = {
  given TopLevel = ???
  val internal1 = new RTDomain():
    val ii = new RTDomain():
      val x = SInt(16) <> IN
  internal1.ii.x // `.x` accessed using `selectDynamic`
}

Output

Compiling project (Scala 3.3.1-RC7, JVM)
[error] ./main.scala:48:16
[error] Recursion limit exceeded.
[error] Maybe there is an illegal cyclic reference?
[error] If that's not the case, you could also try to increase the stacksize using the -Xss JVM option.
[error] For the unprocessed stack trace, compile with -Yno-decode-stacktraces.
[error] A recurring operation is (inner to outer):
[error] 
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   ...
[error] 
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#given_TScope
[error]   find-member RTDomain#x
[error]   internal1.ii.x
[error]                ^
Error compiling project (S

Expectation

Should compile

@WojciechMazur WojciechMazur added itype:bug stat:needs minimization Needs a self contained minimization area:implicits related to implicits regression This worked in a previous version but doesn't anymore stat:needs bisection Need to use nightly builds and git bisect to find out the commit where this issue was introduced labels Aug 31, 2023
@soronpo
Copy link
Contributor

soronpo commented Aug 31, 2023

Was already minimized. See #18263

@soronpo soronpo closed this as completed Aug 31, 2023
@WojciechMazur WojciechMazur removed the stat:needs bisection Need to use nightly builds and git bisect to find out the commit where this issue was introduced label Aug 31, 2023
@dwijnand dwijnand closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:implicits related to implicits itype:bug regression This worked in a previous version but doesn't anymore stat:duplicate stat:needs minimization Needs a self contained minimization
Projects
None yet
Development

No branches or pull requests

3 participants