-
Notifications
You must be signed in to change notification settings - Fork 1.1k
non-private method referring to private type is overeager #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Qualified private simply does not figure in privacy testing. So I am not sure we can do something here. |
When unpickling from Scala 2, we could simply silence errors from checkNoPrivateLeaks by default. |
This issue looks like a show-stopper for using scalatest with dotty. Reproduces for both scalatest |
I think we no longer need to check private leaks when unpickling. We needed that before, when all references were based on names, but that's no longer the case. |
Should be fixed by #4133, let us know if you find more problems using scalatest with dotty. |
Thanks! |
Looking at the Scalatest source, doCollected is
private[scalatest]
, which means that compiling my own project against this code should not result in an error—I can see why it should be an error when building scalatest itself, though.The text was updated successfully, but these errors were encountered: