Skip to content

Tasty version bumping #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasstucki opened this issue Oct 22, 2018 · 1 comment
Closed

Tasty version bumping #5308

nicolasstucki opened this issue Oct 22, 2018 · 1 comment

Comments

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Oct 22, 2018

Originally posted by @odersky in #5307 (comment)

@odersky: I don't know what the policy wrt bumbing the Tasty version is. Say you have two PR's and they each bump the version from 11 to 12. Then what is the right version? Alternatively, could we bump the TASTY version only for each release if there is a change in TASTY? That would limit the bumping speed to at most one every 6 weeks or so. I am not sure what scheme is preferable. What do others think?

@smarter
Copy link
Member

smarter commented Oct 23, 2018

Say you have two PR's and they each bump the version from 11 to 12. Then what is the right version?

Once once of the PR has landed, the other should be rebased to bump to 13.

Alternatively, could we bump the TASTY version only for each release if there is a change in TASTY?

Bumping tasty when we notice that we break it is good practice for when we'll start getting serious about stabilizing it I think. Additionally, because of incremental compilation, we sometimes end up mixing up tasty from different compiler instances, this can lead to weird errors if we don't bump the tasty version to get a hard failure on unpickling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants