Skip to content

Set versionScheme of scala3-library artifact #13498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Set versionScheme of scala3-library artifact #13498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c9af7d
Set versionScheme of scala3-library artifact
julienrf Sep 10, 2021
82ec2dc
Declare versioning scheme of scala3-interfaces and tasty-core
julienrf Sep 10, 2021
00941d7
Enable MiMa on project tasty-core-bootstrapped
julienrf Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:

- name: MiMa
run: |
./project/scripts/sbt ";scala3-interfaces/mimaReportBinaryIssues ;scala3-library-bootstrapped/mimaReportBinaryIssues ;scala3-library-bootstrappedJS/mimaReportBinaryIssues"
./project/scripts/sbt ";scala3-interfaces/mimaReportBinaryIssues ;scala3-library-bootstrapped/mimaReportBinaryIssues ;scala3-library-bootstrappedJS/mimaReportBinaryIssues; tasty-core-bootstrapped/mimaReportBinaryIssues"

test_windows_fast:
runs-on: [self-hosted, Windows]
Expand Down
16 changes: 14 additions & 2 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,10 @@ object Build {

lazy val `scala3-interfaces` = project.in(file("interfaces")).
settings(commonJavaSettings).
settings(commonMiMaSettings)
settings(commonMiMaSettings).
settings(
versionScheme := Some("semver-spec")
)

/** Find an artifact with the given `name` in `classpath` */
def findArtifact(classpath: Def.Classpath, name: String): File = classpath
Expand Down Expand Up @@ -1760,6 +1763,7 @@ object Build {
val base =
project.withCommonSettings.
settings(
versionScheme := Some("semver-spec"),
libraryDependencies += "org.scala-lang" % "scala-library" % stdlibVersion,
// Make sure we do not refer to experimental features outside an experimental scope.
// In other words, disable NIGHTLY/SNAPSHOT experimental scope.
Expand All @@ -1785,7 +1789,15 @@ object Build {
def asTastyCore(implicit mode: Mode): Project = project.withCommonSettings.
dependsOn(dottyLibrary).
settings(tastyCoreSettings).
settings(disableDocSetting)
settings(disableDocSetting).
settings(
versionScheme := Some("semver-spec"),
if (mode == Bootstrapped) {
commonMiMaSettings
} else {
Nil
}
)

def asTastyCoreScala2: Project = project.settings(commonScala2Settings)

Expand Down