Skip to content

Commit 80ea27d

Browse files
committed
Remove exception.escaped attribute (as per SIG mtg).
1 parent 67e2c98 commit 80ea27d

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

specification/trace/api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -516,8 +516,8 @@ MUST record an exception as an `Event` with the conventions outlined in the
516516

517517
Examples:
518518

519-
- `RecordException(exception: Exception, escaped: boolean? = null)`
520-
- `RecordException(type: String, message: String, stacktrace: String, escaped: boolean?)`
519+
- `RecordException(exception: Exception)`
520+
- `RecordException(type: String, message: String, stacktrace: String)`
521521

522522
### Span lifetime
523523

specification/trace/semantic_conventions/exceptions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Span span = myTracer.startSpan(/*...*/);
4343
try {
4444
// original code
4545
} catch (Throwable e) {
46-
span.recordException(e, /*escaped=*/true);
46+
span.recordException(e); // We know that the exception is escaping here.
4747
throw e;
4848
} finally {
4949
span.end();
@@ -60,7 +60,6 @@ their types.
6060
| exception.type | String | The type of the exception (its fully-qualified class name, if applicable). The dynamic type of the exception should be preferred over the static type in languages that support it. E.g. "java.net.ConnectException", "OSError" | One of `exception.type` or `exception.message` is required |
6161
| exception.message | String | The exception message. E.g. `"Division by zero"`, `"Can't convert 'int' object to str implicitly"` | One of `exception.type` or `exception.message` is required |
6262
| exception.stacktrace | String | A stacktrace as a string in the natural representation for the language runtime. The representation is to be determined and documented by each language SIG. E.g. `"Exception in thread \"main\" java.lang.RuntimeException: Test exception\n at com.example.GenerateTrace.methodB(GenerateTrace.java:13)\n at com.example.GenerateTrace.methodA(GenerateTrace.java:9)\n at com.example.GenerateTrace.main(GenerateTrace.java:5)"`. | No |
63-
| exception.escaped | Bool | SHOULD be set to true if the exception event is recoded at a point where it is known that the exception is escaping the scope of the span (e.g. if there is an exception active just before ending the Span). Note that an exception may still leave the scope of the span even if this was not set or set to false, if the event was recorded at an earlier time. | No |
6463

6564
### Stacktrace Representation
6665

0 commit comments

Comments
 (0)