fixed yiisoft#17708 (intl number formatter)

Author: schmunk42

framework/i18n/Formatter.php

@@ -1219,9 +1219,14 @@ public function asScientific($value, $decimals = null, $options = [], $textOptio
         if ($value === null) {
             return $this->nullDisplay;
         }
+
         $value = $this->normalizeNumericValue($value);
 
         if ($this->_intlLoaded) {
+            // fix for https://github.com/yiisoft/yii2/issues/17708
+            if ($decimals !== null) {
+                $decimals++;
+            }
             $f = $this->createNumberFormatter(NumberFormatter::SCIENTIFIC, $decimals, $options, $textOptions);
             if (($result = $f->format($value)) === false) {
                 throw new InvalidArgumentException('Formatting scientific number value failed: ' . $f->getErrorCode() . ' ' . $f->getErrorMessage());

tests/framework/i18n/FormatterNumberTest.php

@@ -515,7 +515,7 @@ public function testAsCurrency()
     public function testIntlAsScientific()
     {
         $value = '123';
-        $this->assertSame('1.23E2', $this->formatter->asScientific($value));
+        $this->assertSame('1.23E2', $this->formatter->asScientific($value, 2));
         $value = '123456';
         $this->assertSame('1.23456E5', $this->formatter->asScientific($value));
         $value = '-123456.123';
@@ -528,7 +528,10 @@ public function testIntlAsScientific()
         // null display
         $this->assertSame($this->formatter->nullDisplay, $this->formatter->asScientific(null));
 
-        $this->assertSame('8.76543210987654E16', $this->formatter->asScientific('87654321098765436'));
+        // precision (see also https://github.com/yiisoft/yii2/issues/17708)
+        $this->assertSame('9E16', $this->formatter->asScientific('87654321098765436', 0));
+        $this->assertSame('8.8E16', $this->formatter->asScientific('87654321098765436', 1));
+        $this->assertSame('8.765432109877E16', $this->formatter->asScientific('87654321098765436', 12));
     }
 
     public function testAsScientific()
@@ -548,6 +551,11 @@ public function testAsScientific()
         $this->assertSame($this->formatter->nullDisplay, $this->formatter->asScientific(null));
 
         $this->assertSame('8.765432E+16', $this->formatter->asScientific('87654321098765436'));
+
+        // precision (see also https://github.com/yiisoft/yii2/issues/17708)
+        $this->assertSame('9E+16', $this->formatter->asScientific('87654321098765436', 0));
+        $this->assertSame('8.8E+16', $this->formatter->asScientific('87654321098765436', 1));
+        $this->assertSame('8.765432109877E+16', $this->formatter->asScientific('87654321098765436', 12));
     }
 
     public function testIntlAsSpellout()