Skip to content

Commit 081cb74

Browse files
authored
Sander/normalize line endings (#201)
* Saving files before refreshing line endings * normalized files * fix(line-endings): convert line-endings to `lf` only, to prevent problems running scully in CI closes #192
1 parent 6486e68 commit 081cb74

95 files changed

Lines changed: 671 additions & 694 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitattributes

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Set the default behavior, in case people don't have core.autocrlf set.
2+
* text=auto
3+
4+
# Explicitly declare text files you want to always be normalized and converted
5+
# to native line endings on checkout.
6+
*.ts text eol=lf
7+
*.js text eol=lf
8+
9+
# Declare files that will always have CRLF line endings on checkout.
10+
# *.sln text eol=crlf
11+
12+
# Denote all files that are truly binary and should not be modified.
13+
*.png binary
14+
*.jpg binary

.github/ISSUE_TEMPLATE/----docs-report.md

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,46 +4,47 @@ about: Suggest a fix or improvement to Scully docs
44
title: ''
55
labels: documentation
66
assignees: ''
7-
8-
---
9-
10-
# 🗄️ Docs report
7+
---# 🗄️ Docs report
118

129
### Description
1310

1411
<!-- ✍️edit:--> A clear and concise description of the problem...
1512

1613
## 🔬 Minimal Reproduction
1714

18-
### What's the affected URL?**
19-
<!-- ✍️edit:-->
15+
### What's the affected URL?\*\*
16+
17+
<!-- ✍️edit:-->
18+
19+
### Reproduction Steps\*\*
2020

21-
### Reproduction Steps**
2221
<!-- If applicable please list the steps to take to reproduce the issue -->
2322
<!-- ✍️edit:-->
2423

25-
### Expected vs Actual Behavior**
24+
### Expected vs Actual Behavior\*\*
25+
2626
<!-- If applicable please describe the difference between the expected and actual behavior after following the repro steps. -->
2727
<!-- ✍️edit:-->
2828

29-
3029
## 📷Screenshot
30+
3131
<!-- Often a screenshot can help to capture the issue better than a long description. -->
3232
<!-- ✍️upload a screenshot:-->
3333

34-
3534
## 🔥 Exception or Error
35+
3636
<pre><code>
3737
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
3838
<!-- ✍️-->
3939

4040
</code></pre>
4141

42-
43-
## 🌍 Your Environment
42+
## 🌍 Your Environment
4443

4544
### Browser info
45+
4646
<!-- ✍️Is this a browser specific issue? If so, please specify the device, browser, and version. -->
4747

4848
### Anything else relevant?
49+
4950
<!-- ✍️Please provide additional info if necessary. -->

.github/ISSUE_TEMPLATE/---bug-report.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,32 @@ about: Report a bug in Scully
44
title: ''
55
labels: bug
66
assignees: ''
7-
8-
---
9-
10-
# 🐞 Bug report
7+
---# 🐞 Bug report
118

129
### Description
1310

1411
## 🔬 Minimal Reproduction
1512

16-
## 💻Your Environment
13+
## 💻Your Environment
14+
1715
**Angular Version:**
16+
1817
<pre><code>
1918
<!-- run `ng version` and paste output below -->
2019
<!-- ✍️-->
2120

2221
</code></pre>
2322

2423
**Scully Version:**
24+
2525
<pre><code>
2626
<!-- Check `package.json` and paste output below -->
2727
<!-- ✍️-->
2828

2929
</code></pre>
30+
3031
## 🔥 Exception or Error
32+
3133
<pre><code>
3234
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
3335
<!-- ✍️-->

.github/ISSUE_TEMPLATE/---feature-request.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,16 @@ about: Suggest an idea for Scully
44
title: ''
55
labels: enhancement
66
assignees: ''
7-
8-
---
9-
10-
# 🧩 Feature request
11-
7+
---# 🧩 Feature request
128

139
### Description
10+
1411
<!-- ✍️--> A clear and concise description of the problem or missing capability...
1512

1613
### Describe the solution you'd like
17-
<!-- ✍️--> If you have a solution in mind, please describe it.
1814

15+
<!-- ✍️--> If you have a solution in mind, please describe it.
1916

2017
### Describe alternatives you've considered
18+
2119
<!-- ✍️--> Have you considered any alternative solutions or workarounds?

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
## PR Checklist
2+
23
Please check if your PR fulfills the following requirements:
34

45
- [ ] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
56
- [ ] Tests for the changes have been added (for bug fixes / features)
67
- [ ] Docs have been added / updated (for bug fixes / features)
78

8-
99
## PR Type
10+
1011
What kind of change does this PR introduce?
1112

1213
<!-- Please check the one that applies to this PR using "x". -->
@@ -17,23 +18,19 @@ What kind of change does this PR introduce?
1718
- [ ] Refactoring (no functional changes, no api changes)
1819
- [ ] Other... Please describe:
1920

20-
2121
## What is the current behavior?
22+
2223
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
2324

2425
Issue Number: N/A
2526

26-
2727
## What is the new behavior?
2828

29-
3029
## Does this PR introduce a breaking change?
3130

3231
- [ ] Yes
3332
- [ ] No
3433

35-
3634
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
3735

38-
3936
## Other information

.vscode/settings.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
2-
"cSpell.words": [
3-
"Scully",
4-
"Scullyio"
5-
],
2+
"cSpell.words": ["Scully", "Scullyio"],
63
"peacock.affectActivityBar": true,
74
"peacock.affectTitleBar": true,
85
"peacock.affectStatusBar": true,

README.md

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http://commitizen.github.io/cz-cli/)
66
[![CLA assistant](https://cla-assistant.io/readme/badge/scullyio/scully)](https://cla-assistant.io/scullyio/scully)
77

8-
98
The best way to build the fastest Angular apps. Scully is a static site generator for Angular projects looking to embrace the JAMStack.
109

1110
- [Getting Started](docs/getting-started.md)
@@ -14,53 +13,53 @@ The best way to build the fastest Angular apps. Scully is a static site generato
1413
- [Contribution Guideline](CONTRIBUTING.md)
1514

1615
# What is Scully?
17-
Scully pre-renders each page in your app to plain HTML & CSS. To do this, Scully uses machine learning techniques to find
16+
17+
Scully pre-renders each page in your app to plain HTML & CSS. To do this, Scully uses machine learning techniques to find
1818
all of the routes in your project. Scully then visits each route, rendering the view and saving it to an HTML file.
1919

20-
You can then ship all of those HTML files to production. Each view in your app can now be delivered to your users in just
21-
a few KBs, as opposed to the hundreds/thousands of KBs require to download your entire Angular app.
20+
You can then ship all of those HTML files to production. Each view in your app can now be delivered to your users in just
21+
a few KBs, as opposed to the hundreds/thousands of KBs require to download your entire Angular app.
2222

23-
Your app appears INSTANTLY on any device (including mobile 3G).
23+
Your app appears INSTANTLY on any device (including mobile 3G).
2424

2525
Once the fully-rendered HTML arrives/appears on the user's view, your Angular app will then load and bootstrap on top of
2626
the existing view. This means that Scully gives you the best of both worlds:
2727

28-
1. The ability to pre-render your entire app to the most base form of HTML & CSS.
29-
2. The ability to still have a full powered SPA written in Angular.
28+
1. The ability to pre-render your entire app to the most base form of HTML & CSS.
29+
2. The ability to still have a full powered SPA written in Angular.
3030

31-
When your app is pre-rendered, users no longer wait until all the JavaScript has downloaded, parsed and executed before
31+
When your app is pre-rendered, users no longer wait until all the JavaScript has downloaded, parsed and executed before
3232
they can see and interact with your website. They can immediately begin to see and interact with the page. When your page
33-
is IMMEDIATELY available, you will have less abandoned sessions and a much higher conversion rate on your website.
33+
is IMMEDIATELY available, you will have less abandoned sessions and a much higher conversion rate on your website.
3434

3535
This also means that you may not need to ship your backend to production. Because the view is pre-rendered and the
36-
data is fetched at build time, all views that can run without the backend in prod CAN run without the backend in prod.
37-
The security and cost implications to that fact can be mind blowing when you think about them.
36+
data is fetched at build time, all views that can run without the backend in prod CAN run without the backend in prod.
37+
The security and cost implications to that fact can be mind blowing when you think about them.
3838

3939
For those wanting to know more about this process, please read the [Getting Started](docs/getting-started.md) guide. For
4040
those who want to know more about the theory behind pre-rendering JavaScript SPAs, our friends at [Netlify](https://netlify.com)
41-
wrote a [free book about the JAMStack](https://www.netlify.com/pdf/oreilly-modern-web-development-on-the-jamstack.pdf).
42-
Check that out today.
41+
wrote a [free book about the JAMStack](https://www.netlify.com/pdf/oreilly-modern-web-development-on-the-jamstack.pdf).
42+
Check that out today.
4343

4444
#### GET A HOLD OF US 24/7
45+
4546
The Scully core team wants to help you any time you need us. We don’t want you to get stuck without help. To make this possible, you have the following ways to get a hold of our team:
4647

4748
1. The ScullyIO [Gitter channel](https://gitter.im/scullyio/community) is available to the public, and you can chat questions to us in real time, one of the core team (or the community members) will be there to reply to it.
4849

4950
1. Each Tuesday we have Office Hours at noon MDT. [You can join](https://meet.google.com/_meet/vcm-wekz-hsx) the entire team and ask your questions.
5051

51-
1. Our DMs are open on [Twitter](https://twitter.com/scullyio). Feel free to reach out to us on Twitter.
52-
52+
1. Our DMs are open on [Twitter](https://twitter.com/scullyio). Feel free to reach out to us on Twitter.
5353

5454
## Core Team
5555

56-
| Aaron Frost | Sander Elias | Jorge Cano | Andres Villanueva |
57-
| ------------------------------------------------------------------------- | --------------------------------------------------------------------------- | --------------------------------------------------------------------------- | ---------------------------------------------------------------------------------|
58-
| ![Aaron Frost](https://avatars0.githubusercontent.com/u/662832?s=120&v=4&1) | ![Sander Elias](https://avatars3.githubusercontent.com/u/1249083?s=120&v=4) | ![Jorge Cano](https://avatars3.githubusercontent.com/u/5982204?s=120&v=4) | ![Andres Villanueva](https://avatars0.githubusercontent.com/u/1209238?s=120&v=4) |
59-
| [aaronfrost](https://github.com/aaronfrost) | [SanderElias](https://github.com/SanderElias) | [jorgeucano](https://github.com/jorgeucano) | [villanuevand](https://github.com/villanuevand) |
56+
| Aaron Frost | Sander Elias | Jorge Cano | Andres Villanueva |
57+
| --------------------------------------------------------------------------- | --------------------------------------------------------------------------- | ------------------------------------------------------------------------- | -------------------------------------------------------------------------------- |
58+
| ![Aaron Frost](https://avatars0.githubusercontent.com/u/662832?s=120&v=4&1) | ![Sander Elias](https://avatars3.githubusercontent.com/u/1249083?s=120&v=4) | ![Jorge Cano](https://avatars3.githubusercontent.com/u/5982204?s=120&v=4) | ![Andres Villanueva](https://avatars0.githubusercontent.com/u/1209238?s=120&v=4) |
59+
| [aaronfrost](https://github.com/aaronfrost) | [SanderElias](https://github.com/SanderElias) | [jorgeucano](https://github.com/jorgeucano) | [villanuevand](https://github.com/villanuevand) |
6060

61+
#### Created by
6162

62-
#### Created by
6363
![logo Hero Devs](assets/hero-devs-logo-80x80.jpg)
6464

65-
***HeroDevs. LLC***
66-
65+
**_HeroDevs. LLC_**

blog/page-2.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ author: Sander Elias
44
publish date: 2019-11-27
55
description: This is the second demo page in this sample.
66
---
7+
78
# Page 2
89

910
## its a wild world after all
1011

1112
```typescript
12-
console.log('amazing')
13+
console.log('amazing');
1314
```
1415

1516
Related information [page-3](/blog/page-3)
1617

1718
[site-map](/home)
18-

0 commit comments

Comments
 (0)