fix(staticserve): make sure 404 is handled correctly at staticserve

* chore(update to latest cli and core): angular update t o latest

* fix(staticserver): make sure 404 works as expected

* fix(staticserve): make sure 404 is handled correctly at staticserve

in some circumstances our server would serve the wrong files, this PR will fix that.

Author: SanderElias

package-lock.json

@@ -3,6 +3,7 @@
   "version": "0.0.2",
   "scripts": {
     "ng": "ng",
+    "tsc": "tsc",
     "start": "ng serve",
     "build": "ng build",
     "test": "ng test",
@@ -28,27 +29,26 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "~9.0.0-rc.6",
-    "@angular/common": "~9.0.0-rc.6",
-    "@angular/compiler": "~9.0.0-rc.6",
-    "@angular/core": "~9.0.0-rc.6",
-    "@angular/forms": "~9.0.0-rc.6",
-    "@angular/platform-browser": "~9.0.0-rc.6",
-    "@angular/platform-browser-dynamic": "~9.0.0-rc.6",
-    "@angular/platform-server": "~9.0.0-rc.6",
-    "@angular/router": "~9.0.0-rc.6",
-    "request": "^2.88.0",
+    "@angular/animations": "~9.0.0-rc.7",
+    "@angular/common": "~9.0.0-rc.7",
+    "@angular/compiler": "~9.0.0-rc.7",
+    "@angular/core": "~9.0.0-rc.7",
+    "@angular/forms": "~9.0.0-rc.7",
+    "@angular/platform-browser": "~9.0.0-rc.7",
+    "@angular/platform-browser-dynamic": "~9.0.0-rc.7",
+    "@angular/platform-server": "~9.0.0-rc.7",
+    "@angular/router": "~9.0.0-rc.7",
     "rxjs": "^6.5.3",
     "semver": "^6.3.0",
     "tslib": "^1.10.0",
     "zone.js": "~0.10.2"
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^0.900.0-rc.7",
-    "@angular-devkit/build-ng-packagr": "~0.900.0-rc.5",
-    "@angular/cli": "~9.0.0-rc.5",
-    "@angular/compiler-cli": "~9.0.0-rc.6",
-    "@angular/language-service": "~9.0.0-rc.6",
+    "@angular-devkit/build-ng-packagr": "~0.900.0-rc.7",
+    "@angular/cli": "~9.0.0-rc.7",
+    "@angular/compiler-cli": "~9.0.0-rc.7",
+    "@angular/language-service": "~9.0.0-rc.7",
     "@bazel/bazel": "^1.2.0",
     "@bazel/buildifier": "^0.29.0",
     "@bazel/ibazel": "^0.10.3",

package.json

@@ -20,7 +20,11 @@ const routes: Routes = [
     loadChildren: () => import('./user/user.module').then(m => m.UserModule),
   },
   {path: 'demo', loadChildren: () => import('./demo/demo.module').then(m => m.DemoModule)},
-  // {path: '', redirectTo: '/home/', pathMatch: 'full'}
+  {path: '', redirectTo: '/home', pathMatch: 'full'},
+  {
+    path: '**',
+    loadChildren: () => import('./pagenotfound/pagenotfound.module').then(m => m.PagenotfoundModule),
+  },
 ];
 
 @NgModule({

projects/sampleBlog/src/app/app-routing.module.ts

@@ -0,0 +1,12 @@
+import { NgModule } from '@angular/core';
+import { Routes, RouterModule } from '@angular/router';
+
+import { PagenotfoundComponent } from './pagenotfound.component';
+
+const routes: Routes = [{ path: '', component: PagenotfoundComponent }];
+
+@NgModule({
+  imports: [RouterModule.forChild(routes)],
+  exports: [RouterModule]
+})
+export class PagenotfoundRoutingModule { }

projects/sampleBlog/src/app/pagenotfound/pagenotfound-routing.module.ts

@@ -0,0 +1 @@
+<p>pagenotfound works!</p>

projects/sampleBlog/src/app/pagenotfound/pagenotfound.component.css

@@ -0,0 +1,25 @@
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
+
+import { PagenotfoundComponent } from './pagenotfound.component';
+
+describe('PagenotfoundComponent', () => {
+  let component: PagenotfoundComponent;
+  let fixture: ComponentFixture<PagenotfoundComponent>;
+
+  beforeEach(async(() => {
+    TestBed.configureTestingModule({
+      declarations: [ PagenotfoundComponent ]
+    })
+    .compileComponents();
+  }));
+
+  beforeEach(() => {
+    fixture = TestBed.createComponent(PagenotfoundComponent);
+    component = fixture.componentInstance;
+    fixture.detectChanges();
+  });
+
+  it('should create', () => {
+    expect(component).toBeTruthy();
+  });
+});

projects/sampleBlog/src/app/pagenotfound/pagenotfound.component.html

@@ -0,0 +1,15 @@
+import { Component, OnInit } from '@angular/core';
+
+@Component({
+  selector: 'app-pagenotfound',
+  templateUrl: './pagenotfound.component.html',
+  styleUrls: ['./pagenotfound.component.css']
+})
+export class PagenotfoundComponent implements OnInit {
+
+  constructor() { }
+
+  ngOnInit() {
+  }
+
+}

projects/sampleBlog/src/app/pagenotfound/pagenotfound.component.spec.ts

@@ -0,0 +1,15 @@
+import { NgModule } from '@angular/core';
+import { CommonModule } from '@angular/common';
+
+import { PagenotfoundRoutingModule } from './pagenotfound-routing.module';
+import { PagenotfoundComponent } from './pagenotfound.component';
+
+
+@NgModule({
+  declarations: [PagenotfoundComponent],
+  imports: [
+    CommonModule,
+    PagenotfoundRoutingModule
+  ]
+})
+export class PagenotfoundModule { }

projects/sampleBlog/src/app/pagenotfound/pagenotfound.component.ts

@@ -1,15 +1,13 @@
 import {parseAngularRoutes} from 'guess-parser';
 import {scullyConfig} from '../utils/config';
 
-export const traverseAppRoutes = async (
-  appRootFolder = scullyConfig.projectRoot
-) => {
+export const traverseAppRoutes = async (appRootFolder = scullyConfig.projectRoot) => {
   try {
     const routes = parseAngularRoutes(appRootFolder).map(r => r.path);
 
     return routes;
   } catch (e) {
-    // console.log('e',e)
+    console.log('e', e);
     throw new Error('Scully could not traverse routes');
   }
 };