feat(scully): Add replaceFirstRouteParamWithVal util #123
Merged
SanderElias merged 2 commits intomasterfrom Jan 3, 2020
Merged
feat(scully): Add replaceFirstRouteParamWithVal util #123SanderElias merged 2 commits intomasterfrom
SanderElias merged 2 commits intomasterfrom
Conversation
Often people will need to replace the first route param with a value. To prevent them from recreating the split logic and join logic and break logic, this function is a reusable util that people can use.
others can use it via npm.
|
|
aaronfrost
changed the title
Contributor
|
@aaronfrost I think this functionality should be merged with the routeSplit utility. Perhaps we should extend that function to include the partial replacements you are doing? |
Contributor
Author
|
Yeah. I agree. I was not sure where we should put this. Since the utils were all in their own file, I wasn't sure if I should add it in or put it in it's own file. What do you think we should do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
I have added a util function for plugin authors who need to replace the first parameterized value in a route with a provided value. It is simple, but could go wrong.
What is the current behavior?
this will make life easier for plugin authors who will be doing this often.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information