Skip to content

Schematics/fix pre alpha#15

Merged
jorgeucano merged 3 commits intomasterfrom
schematics/fix-pre-alpha
Dec 16, 2019
Merged

Schematics/fix pre alpha#15
jorgeucano merged 3 commits intomasterfrom
schematics/fix-pre-alpha

Conversation

@jorgeucano
Copy link
Copy Markdown
Contributor

@jorgeucano jorgeucano commented Dec 15, 2019 •
edited
Loading

  • Remove file copy for move with support for rewrite
  • Fix support scully.config.js route
  • Fix template for markdown
  • Add how to test the PR in README.md
  • full support for rc
  • rename flag in schematic post for full support
  • add name with space support into post schematic

How to test:

cd schematics/scully
npm run build
npm pack
cp -r scullyio-init-0.0.4.tgz {{angular_project_folder}}
cd {{angular_project_folder}}
npm i --save scullyio-init-0.0.4.tgz
ng g .\node_modules\@scullyio\init\src\collection.json:ng-add
ng g .\node_modules\@scullyio\init\src\collection.json:blog
ng g .\node_modules\@scullyio\init\src\collection.json:post --name="This is my post"
ng g .\node_modules\@scullyio\init\src\collection.json:markdown --name=test --slug=idid
ng build --prod
npm run scully

@jorgeucano jorgeucano requested a review from a team December 15, 2019 17:59
aaronfrost
aaronfrost reviewed Dec 16, 2019
View reviewed changes
Comment thread schematics/scully/src/add-post/index.ts Outdated
Comment thread schematics/scully/src/add-post/index.ts
aaronfrost
aaronfrost reviewed Dec 16, 2019
View reviewed changes
Comment thread schematics/scully/src/create-blog/index.ts
SanderElias
SanderElias approved these changes Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano merged commit 666e886 into master Dec 16, 2019
@jorgeucano jorgeucano deleted the schematics/fix-pre-alpha branch December 16, 2019 10:46
Jefiozie pushed a commit to Jefiozie/scully that referenced this pull request Feb 9, 2023
@SanderElias
feat(platform-server): ➕ added platform-server lib back (scullyio#15)
b74f045 
* feat(platform-server): ➕ added platform-server lib back

* fix(platform-server): ✨ add symlinks to be able to use sps

* refactor(platform-server): ♻️ mode sample-blog to ESM imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronfrost aaronfrost aaronfrost approved these changes

@SanderElias SanderElias SanderElias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorgeucano @aaronfrost @SanderElias