fix(scully-routes.service): fix missing return type#172
Merged
aaronfrost merged 2 commits intomasterfrom Jan 10, 2020
Merged
Conversation
Put in the correct type for the return of the getCurrent function. In some cases TS inferrrence is off otherwise closes #171
aaronfrost
reviewed
Jan 10, 2020
Contributor
aaronfrost
left a comment
aaronfrost
left a comment
There was a problem hiding this comment.
I think you should add return types to every function and public member var of this class. This will fix countless future problems.
aaronfrost
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put in the correct type for the return of the getCurrent function. In some cases TS inferrrence is
off otherwise
closes #171
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
typing of the getCurrent method is off
Issue Number: #171
What is the new behavior?
It returns the correct type.
Does this PR introduce a breaking change?
Other information