refactoring/tests ng add#176
Merged
jorgeucano merged 5 commits intoscullyio:masterfrom Jan 15, 2020
d-koppenhagen:fix/ng-add
Merged
refactoring/tests ng add#176jorgeucano merged 5 commits intoscullyio:masterfrom d-koppenhagen:fix/ng-add
ng add#176jorgeucano merged 5 commits intoscullyio:masterfrom
d-koppenhagen:fix/ng-add
Conversation
this tests will verify that the other schematics (blog, scully) as well as the NodePackageInstallTask will be called
Contributor
Author
|
@jorgeucano please have a look at it. It should harden the |
This was referenced Jan 10, 2020
aaronfrost
reviewed
Jan 13, 2020
Contributor
Author
|
@aaronfrost should be ready to merge now. But #177 should be merged as well after it as it contains a lot of tests and some more minor fixes. |
jorgeucano
reviewed
Jan 15, 2020
jorgeucano
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ng-adddidn't work (0.0.10)What is the new behavior?
Verification that other schematics will be called when running
ng-addDoes this PR introduce a breaking change?
Other information