refactor/cleanup: scully schematics#177
Merged
jorgeucano merged 27 commits intoscullyio:masterfrom Jan 15, 2020
d-koppenhagen:refactor/schematics-scully
Merged
refactor/cleanup: scully schematics#177jorgeucano merged 27 commits intoscullyio:masterfrom d-koppenhagen:refactor/schematics-scully
jorgeucano merged 27 commits intoscullyio:masterfrom
d-koppenhagen:refactor/schematics-scully
Conversation
Contributor
Author
|
#176 should be merged first |
d-koppenhagen
changed the title
Contributor
|
@jorgeucano I am going to let you review this. |
10 tasks
Contributor
|
@d-koppenhagen i will test this today and check all the test in angular ! |
Contributor
Author
|
Perfect! |
Contributor
|
remove the prompt and i will approve :) |
Contributor
Author
|
@jorgeucano done :) |
jorgeucano
approved these changes
Jan 15, 2020
Contributor
|
This branch has conflicts that must be resolved :) @d-koppenhagen fix this and i will merge |
Contributor
Author
|
@jorgeucano #176 has to be merged first. |
- use existing utils to read and write `package.json` config parts - split logic into smaller chainable functions - provide aditional tests - remove unused schema option `project`
avoid duplicat / mismatching code
...when disabling it via options
...and test it
Contributor
Author
|
@jorgeucano done. |
jorgeucano
approved these changes
Jan 15, 2020
Contributor
|
done, thanks for all your work :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
package.jsonconfig partsproject