fix(remove httpclientmodule): refactor to drop depedency on httpClien…#182
Merged
SanderElias merged 8 commits intomasterfrom Jan 15, 2020
Merged
fix(remove httpclientmodule): refactor to drop depedency on httpClien…#182SanderElias merged 8 commits intomasterfrom
SanderElias merged 8 commits intomasterfrom
Conversation
…tModule This refactor takes care of the httpClientModule, by replacing it with a fetchHttp from our own making.
…intial page update the tranferstate to prepare it for external JSON, and a little optimized flow
aaronfrost
reviewed
Jan 14, 2020
…d 301 read the index.html instead of the urls itself. Saves a round-trip to the server.
…_ routing Make sure state is only emitted after routing has finished, to make sure the state doesn't get transfered to the old page.
…g navigation This makes sure the state doesn't get emmited before navigation is done.
with this, the getstate will _never_ emit a value **during** navigation. Only when navigation is done, the state will be available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tModule
This refactor takes care of the httpClientModule, by replacing it with a fetchHttp from our own
making.
@aaronfrost I tested it true, but I a bit wary about the tranferstate in this one. Can you double-check before we merge this one?