Skip to content

improvement(cofig.ts): throw an error when ./dist is used as output…#188

Merged
SanderElias merged 1 commit intomasterfrom
sander/explainDistinDocs
Jan 16, 2020
Merged

improvement(cofig.ts): throw an error when ./dist is used as output…#188
SanderElias merged 1 commit intomasterfrom
sander/explainDistinDocs

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

…path in angular.json

We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that,
and also make scully check, and throw en error when this is detected

re #56

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Scully will not copy in assets, and other "strange" behavior might happen when ./dist is chosen as outputPath in angular.json.

What is the new behavior?

Documented this behavior, and put in a check inside config.ts to throw an error when this setting is found

Does this PR introduce a breaking change?

  • Yes
  • No

…path in angular.json

We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that,
and also make scully check, and throw en error when this is detected

re #56
Copy link
Copy Markdown
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SanderElias SanderElias merged commit 2514dd1 into master Jan 16, 2020
@SanderElias SanderElias deleted the sander/explainDistinDocs branch January 16, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants