improvement(cofig.ts): throw an error when ./dist is used as output…#188
Merged
SanderElias merged 1 commit intomasterfrom Jan 16, 2020
Merged
improvement(cofig.ts): throw an error when ./dist is used as output…#188SanderElias merged 1 commit intomasterfrom
./dist is used as output…#188SanderElias merged 1 commit intomasterfrom
Conversation
…path in angular.json We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that, and also make scully check, and throw en error when this is detected re #56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…path in angular.json
We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that,
and also make scully check, and throw en error when this is detected
re #56
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Scully will not copy in assets, and other "strange" behavior might happen when
./distis chosen asoutputPathin angular.json.What is the new behavior?
Documented this behavior, and put in a check inside config.ts to throw an error when this setting is found
Does this PR introduce a breaking change?