fix(ng-add): fix v8 import#189
Merged
jorgeucano merged 2 commits intomasterfrom Jan 17, 2020
Merged
Conversation
SanderElias
approved these changes
Jan 17, 2020
| const ngCoreVersionTag = getPackageVersionFromPackageJson(tree, '@angular/core'); | ||
| let v8 = ''; | ||
| if (+ngCoreVersionTag.search(/(\^8|~8)/g) === 0) { | ||
| v8 = '-8'; |
Contributor
There was a problem hiding this comment.
New version of lib I'm working on is called:
ng-lib-v8 <- notice the v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Schematics import wrong version into app.component when you are in angular v8 project
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information