fix(scullyroutesservice): dont error when nor routefile is found#218
Merged
SanderElias merged 2 commits intomasterfrom Jan 22, 2020
Merged
fix(scullyroutesservice): dont error when nor routefile is found#218SanderElias merged 2 commits intomasterfrom
SanderElias merged 2 commits intomasterfrom
Conversation
When used in a specific way, the routeServie couls error out. This fixes that issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used in a specific way, the route-service coulsderror out. This fixes that issue
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the route file isn't created yet and is used in a specific way, it can error, and break prerendering of the page
What is the new behavior?
doesn't error anymore, and makes sure the page renders correctly
It also removes a stray debug console.log
Does this PR introduce a breaking change?