Skip to content

Sander/css scoping#250

Merged
SanderElias merged 2 commits intomasterfrom
sander/cssScopeing
Jan 30, 2020
Merged

Sander/css scoping#250
SanderElias merged 2 commits intomasterfrom
sander/cssScopeing

Conversation

@SanderElias
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Content rendered through the <scully-content> component could not be styled by using the css off the containing component.

What is the new behavior?

Putting CSS in the component that holds the <scully-content> will now properly style all content that is injected by scully

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR enables the possibillity to use the angular css styles from the holding component in the
blog posts
@SanderElias
Copy link
Copy Markdown
Contributor Author

When this is merged, we need to release the NPM modules at the same time.
Scully-component and the Scully content-render plugin are now using a slightly different way to pass information. both will not work with older versions.

@SanderElias SanderElias merged commit ce599ed into master Jan 30, 2020
@SanderElias SanderElias deleted the sander/cssScopeing branch January 30, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants