Sander/css scoping#250
Merged
SanderElias merged 2 commits intomasterfrom Jan 30, 2020
Merged
Conversation
This PR enables the possibillity to use the angular css styles from the holding component in the blog posts
Contributor
Author
|
When this is merged, we need to release the NPM modules at the same time. |
jorgeucano
approved these changes
Jan 29, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Content rendered through the
<scully-content>component could not be styled by using the css off the containing component.What is the new behavior?
Putting CSS in the component that holds the
<scully-content>will now properly style all content that is injected by scullyDoes this PR introduce a breaking change?
Other information