Skip to content

docs(scully): baseFilter and removeStaticDist#255

Merged
jorgeucano merged 3 commits intomasterfrom
docs-bs-RSD-flags
Jan 31, 2020
Merged

docs(scully): baseFilter and removeStaticDist#255
jorgeucano merged 3 commits intomasterfrom
docs-bs-RSD-flags

Conversation

@Villanuevand
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Add new flags into the docs:

  • baseFilter
  • removeDistFolder

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Villanuevand Villanuevand changed the title docs(scully): baseFilter and removeDistFolder docs(scully): baseFilter and removeStaticDist Jan 30, 2020
Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put in the change, and I'm ok with it then.

Comment thread docs/scully-cmd-line.md Outdated
## baseFilter

```bash
npx scully --baseFilter someRoute
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs the / in front

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

@jorgeucano jorgeucano merged commit 569b316 into master Jan 31, 2020
@jorgeucano jorgeucano deleted the docs-bs-RSD-flags branch January 31, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants