Skip to content

docs(scully): add getting started page spanish translation#264

Merged
Villanuevand merged 2 commits intoscullyio:masterfrom
facurodriguez:docs-spanish-translation
Feb 3, 2020
Merged

docs(scully): add getting started page spanish translation#264
Villanuevand merged 2 commits intoscullyio:masterfrom
facurodriguez:docs-spanish-translation

Conversation

@facurodriguez
Copy link
Copy Markdown
Contributor

@facurodriguez facurodriguez commented Feb 1, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Add getting started page spanish translation

What is the current behavior?

Issue Number: N/A

What is the new behavior?

An almost literal translation of the content present on the current getting started page is performed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

It was decided to make a literal translation to maintain the author's intentionality at the time of writing the guide.

Copy link
Copy Markdown
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me!

I don't see any anchor in getting-started.md to link to the spanish translation...

@Villanuevand
Copy link
Copy Markdown
Contributor

@facurodriguez could you add a anchor link in the getting-started.md to the getting-started_es.md

Copy link
Copy Markdown
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Villanuevand Villanuevand merged commit ccf8679 into scullyio:master Feb 3, 2020
@facurodriguez facurodriguez deleted the docs-spanish-translation branch February 3, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants