fix(hosturl): fix hostURL so the our internal server is not started, …#277
Merged
SanderElias merged 1 commit intomasterfrom Feb 5, 2020
Merged
fix(hosturl): fix hostURL so the our internal server is not started, …#277SanderElias merged 1 commit intomasterfrom
SanderElias merged 1 commit intomasterfrom
Conversation
…and we are quireing dont start the internal server, and use the given one from `hostUrl`
jorgeucano
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and we are requiring
don't start the internal server, and use the given one from
hostUrlPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Internal server starts and the program fails to connect to an external server
What is the new behavior?
Don't start the internal server, and use the external server only
Does this PR introduce a breaking change?
Other information
Note that this doesn't check if the server is available, or is running in the current project. As it's a 3rth party server, we don't have control over this.