Skip to content

fix(ng-lib): correct ModuleWithProviders#75

Merged
SanderElias merged 1 commit intoscullyio:masterfrom
LayZeeDK:LayZeeDK/bugfix/componentsmodule-modulewithprovider
Dec 21, 2019
Merged

fix(ng-lib): correct ModuleWithProviders#75
SanderElias merged 1 commit intoscullyio:masterfrom
LayZeeDK:LayZeeDK/bugfix/componentsmodule-modulewithprovider

Conversation

@LayZeeDK
Copy link
Copy Markdown
Contributor

@LayZeeDK LayZeeDK commented Dec 20, 2019

Correctly expose a ModuleWithProviders.
Fixes #52 and corrects #69

Copy link
Copy Markdown
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit 02059cd into scullyio:master Dec 21, 2019
@LayZeeDK LayZeeDK deleted the LayZeeDK/bugfix/componentsmodule-modulewithprovider branch December 21, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ComponentsModule is importing HttpClientModule

3 participants