Skip to content

Commit 9f43fb0

Browse files
committed
testing: remove cass_session_connect_keyspace from testing_unimplemented
This function is implemented, so it should not be in this file. For some reason, during dynamic linking, the "unimplemented" version of this function is taken and some tests fail due to this. The corresponding tests are now enabled in CI.
1 parent 7d976f8 commit 9f43fb0

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

.github/workflows/build.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,13 @@ jobs:
5050
:ByNameTests.*\
5151
:CompressionTests.*\
5252
:LoggingTests.*\
53+
:PreparedMetadataTests.*\
54+
:UseKeyspaceCaseSensitiveTests.*\
5355
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
5456
:ExecutionProfileTest.InvalidName\
55-
:*NoCompactEnabledConnection"
57+
:*NoCompactEnabledConnection\
58+
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
59+
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
5660
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --scylla --version=release:6.0.0 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"
5761

5862
- name: Upload test logs

.github/workflows/cassandra.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,15 @@ jobs:
5151
:ByNameTests.*\
5252
:CompressionTests.*\
5353
:LoggingTests.*\
54+
:PreparedMetadataTests.*\
55+
:UseKeyspaceCaseSensitiveTests.*\
5456
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
5557
:PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare\
5658
:SslTests.Integration_Cassandra_ReconnectAfterClusterCrashAndRestart\
5759
:ExecutionProfileTest.InvalidName\
58-
:*NoCompactEnabledConnection"
60+
:*NoCompactEnabledConnection\
61+
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
62+
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
5963
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --version=4.0.7 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"
6064

6165
- name: Upload test logs

src/testing_unimplemented.cpp

-6
Original file line numberDiff line numberDiff line change
@@ -295,12 +295,6 @@ CASS_EXPORT CassVersion
295295
cass_schema_meta_version(const CassSchemaMeta* schema_meta){
296296
throw std::runtime_error("UNIMPLEMENTED cass_schema_meta_version\n");
297297
}
298-
CASS_EXPORT CassFuture*
299-
cass_session_connect_keyspace(CassSession* session,
300-
const CassCluster* cluster,
301-
const char* keyspace){
302-
throw std::runtime_error("UNIMPLEMENTED cass_session_connect_keyspace\n");
303-
}
304298
CASS_EXPORT void
305299
cass_session_get_metrics(const CassSession* session,
306300
CassMetrics* output){

0 commit comments

Comments
 (0)