go get github.com/sdboyer/gps fails because /vendor/ is not checked in

[spenczar]

gps happens to require the 2.x branch of github.com/Masterminds/semver, which is not the master branch, but gps does not explicitly vendor its dependencies. That means go get github.com/sdboyer/gps (and its friends, like go test) don't work out of the box.

This took me about 30 minutes to suss out, which is a pretty significant hurdle to jumping in to help on gps/dep.

I'd be happy with loud documentation in CONTRIBUTING.md that says something like "You'll need to run glide install to populate /vendor/ before you can get started." I'd be even happier if the vendor directory were checked in, which would match what github.com/golang/dep does.

[sdboyer]

Glad you're here! 👏 😄

Yeah, this is definitely not the best. Let's keep it simple for now, with a note in CONTRIBUTING.md. gps is going to move directly into dep soon (golang/dep#300), at which point we're probably going to be developing over there, so the considerations related to vendor will be different.

[spenczar]

Thanks for the warm welcome! 😄

I'll write a PR to add some text to CONTRIBUTING.md, that sounds like the right plan.

[fabulous-gopher]

This issue was moved to golang/dep#418