Skip to content
This repository was archived by the owner on Feb 3, 2018. It is now read-only.

Symlinked nested vendor dirs don't get stripped when writing the dep tree #198

Closed
spenczar opened this issue Mar 20, 2017 · 1 comment
Closed

Comments

@spenczar
Copy link
Contributor

Many projects I work on use a symlink for the vendor directory (./vendor -> ./_vendor, typically) because this fools the Go tool into not diving into vendored packages when running stuff like go test ./... - this is one of the solutions out there for golang/go#19090.

gps's WriteDepTree cleans out dependencies' vendor directories, but only does so for ./vendor paths which are proper directories, not symlinks to directories. This breaks dep usage for these projects, since the packages in the nested vendor path are treated as distinct packages with their own separate types by the Go compiler.

@sdboyer
Copy link
Owner

sdboyer commented Mar 21, 2017

symlinks haunt my nightmares

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants