Avoid confusing error on reverse failure #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes people think something went wrong.
avocadoslab
reviewed
Apr 23, 2018
| @@ -96,7 +96,7 @@ protected function isApplied() | |||
|
|
|||
| return $result; | |||
| } catch (\Exception $e) { | |||
| $this->getOutput()->writeln("<comment>{$e->getMessage()}</comment>"); | |||
There was a problem hiding this comment.
would love to know what it currently outputs? Response wasn't helpful?
There was a problem hiding this comment.
Just errors about "unreversed patch detected":
The command "patch --dry-run -p 1 -R < '/vagrant/magento/composer-patches/520-MAGETWO_58033_2_1_2_v1_composer.patch'" failed.
Exit Code: 1(General error)
Working directory: /vagrant/magento
Output:
================
checking file vendor/magento/module-configurable-product/etc/frontend/di.xml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
The next patch, when reversed, would delete the file vendor/magento/module-configurable-product/Plugin/Model/ProductStatus.php,
which does not exist! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored
checking file vendor/magento/module-catalog/view/frontend/templates/product/list.phtml
Unreversed patch detected! Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
patch unexpectedly ends in middle of line
2 out of 2 hunks ignored
pmclain
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes people think something went wrong.