Implemented a custom Detekt rule for JUnit 5 @TestFactory functions that don't have a valid return type. Improved Detekt configuration.

Author: ianbrandt

build-logic/settings.gradle.kts

@@ -19,5 +19,6 @@ dependencyResolutionManagement {
 }
 
 includeBuild("../platforms")
+includeBuild("../detekt-rules")
 
 rootProject.name = "build-logic"

build-logic/src/main/kotlin/org.sdkotlin.buildlogic.detekt-project.gradle.kts

@@ -0,0 +1,27 @@
+plugins {
+	kotlin("jvm")
+	// Version catalog type-safe accessors and extension not yet available in
+	// plugins block of precompiled script plugins:
+	// https://github.com/gradle/gradle/issues/15383
+	// alias(libs.plugins.detekt.gradle.plugin)
+	id("io.gitlab.arturbosch.detekt")
+}
+
+dependencies {
+
+	detektPlugins("org.sdkotlin.detekt:detekt-rules:1.0-SNAPSHOT")
+}
+
+tasks {
+	named<Task>("check").configure {
+		this.setDependsOn(this.dependsOn.filterNot {
+			it is TaskProvider<*> && it.name == "detekt"
+		})
+
+		val detektMain by existing
+		dependsOn(detektMain)
+
+		val detektTest by existing
+		dependsOn(detektTest)
+	}
+}

build-logic/src/main/kotlin/org.sdkotlin.buildlogic.kotlin-project.gradle.kts

@@ -7,10 +7,9 @@ plugins {
 	// https://github.com/gradle/gradle/issues/15383
 	// alias(libs.plugins.dependency.analysis.gradle.plugin)
 	id("com.autonomousapps.dependency-analysis")
-	// alias(libs.plugins.detekt.gradle.plugin)
-	id("io.gitlab.arturbosch.detekt")
 	// alias(libs.plugins.jvm.dependency.conflict.detection.gradle.plugin)
 	id("org.gradlex.jvm-dependency-conflict-detection")
+	id("org.sdkotlin.buildlogic.detekt-project")
 }
 
 val javaTargetVersion: String = JavaVersion.VERSION_21.toString()