Mark a test as errored (instead of skipped) when the file for error_log() capturing cannot be created

Author: sebastianbergmann

src/Framework/Exception/ErrorLogNotWritableException.php

@@ -0,0 +1,23 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\Framework;
+
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ *
+ * @internal This class is not covered by the backward compatibility promise for PHPUnit
+ */
+final class ErrorLogNotWritableException extends Exception
+{
+    public function __construct()
+    {
+        parent::__construct('Could not create writable file for error_log()');
+    }
+}

src/Framework/TestCase.php

@@ -2335,11 +2335,14 @@ private function startErrorLogCapture(): void
         $this->previousErrorLogTarget = ini_set('error_log', $capturePath);
     }
 
+    /**
+     * @throws ErrorLogNotWritableException
+     */
     private function verifyErrorLogExpectation(): void
     {
         if ($this->errorLogCapture === false) {
             if ($this->expectErrorLog) {
-                $this->markTestIncomplete('Could not create writable file for error_log()');
+                throw new ErrorLogNotWritableException;
             }
 
             return;

tests/end-to-end/generic/expect-error-log-fail-with-open_basedir.phpt

@@ -33,10 +33,10 @@ Test Runner Execution Started (1 test)
 Test Suite Started (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest, 1 test)
 Test Preparation Started (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest::testOne)
 Test Prepared (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest::testOne)
-Test Marked Incomplete (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest::testOne)
+Test Errored (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest::testOne)
 Could not create writable file for error_log()
 Test Finished (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest::testOne)
 Test Suite Finished (PHPUnit\TestFixture\ExpectNoErrorLog\ExpectErrorLogFailTest, 1 test)
 Test Runner Execution Finished
 Test Runner Finished
-PHPUnit Finished (Shell Exit Code: 0)
+PHPUnit Finished (Shell Exit Code: 2)

tests/end-to-end/generic/expect-error-log-with-open_basedir.phpt

@@ -24,10 +24,10 @@ Test Suite Started (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest, 1 tes
 Test Preparation Started (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest::testOne)
 Test Prepared (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest::testOne)
 logged a side effect
-Test Marked Incomplete (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest::testOne)
+Test Errored (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest::testOne)
 Could not create writable file for error_log()
 Test Finished (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest::testOne)
 Test Suite Finished (PHPUnit\TestFixture\ExpectErrorLog\ExpectErrorLogTest, 1 test)
 Test Runner Execution Finished
 Test Runner Finished
-PHPUnit Finished (Shell Exit Code: 0)
+PHPUnit Finished (Shell Exit Code: 2)