#5346 Uninstall older non-velopack viewer

if of the same channel

Author: akleshchev

indra/cmake/CMakeLists.txt

@@ -62,6 +62,7 @@ set(cmake_SOURCE_FILES
         UI.cmake
         UnixInstall.cmake
         Variables.cmake
+        Velopack.cmake
         VHACD.cmake
         ViewerMiscLibs.cmake
         VisualLeakDetector.cmake

indra/newview/llstartup.cpp

@@ -29,6 +29,11 @@
 #include "llappviewer.h"
 #include "llstartup.h"
 
+#if LL_VELOPACK && LL_WINDOWS
+#include "llvelopack.h"
+#include <shellapi.h>
+#endif
+
 #if LL_WINDOWS
 #   include <process.h>     // _spawnl()
 #else
@@ -266,6 +271,7 @@ std::unique_ptr<LLViewerStats::PhaseMap> LLStartUp::sPhases(new LLViewerStats::P
 
 void login_show();
 void login_callback(S32 option, void* userdata);
+void uninstall_nsis_if_required();
 void show_release_notes_if_required();
 void show_first_run_dialog();
 bool first_run_dialog_callback(const LLSD& notification, const LLSD& response);
@@ -855,6 +861,7 @@ bool idle_startup()
             initialize_spellcheck_menu();
             init_menus();
         }
+        uninstall_nsis_if_required();
         show_release_notes_if_required();
 
         if (show_connect_box)
@@ -2626,6 +2633,60 @@ void validate_release_notes_coro(const std::string url)
     }
 }
 
+/**
+* Check if this is a fresh velopack install and
+* if uninstallation of old viewer is needed.
+*/
+void uninstall_nsis_if_required()
+{
+#if LL_VELOPACK && LL_WINDOWS
+    if (!LLVelopack::sAfterInstall)
+    {
+        // Only fresh installs
+        return;
+    }
+
+    wchar_t buffer[MAX_PATH];
+    if (!get_nsis_uninstaller_path(buffer, MAX_PATH))
+    {
+        return;
+    }
+
+    LLNotificationsUtil::add("PromptRemoveNsisInstallation", LLSD(), LLSD(),
+        [buffer](const LLSD& notification, const LLSD& response)
+    {
+        S32 option = LLNotificationsUtil::getSelectedOption(notification, response);
+        if (option == 1) // cancel
+        {
+            return;
+        }
+
+        // Launch uninstaller using explorer.exe
+        SHELLEXECUTEINFOW sei = { 0 };
+        sei.cbSize = sizeof(sei);
+        sei.fMask = SEE_MASK_DEFAULT;
+        sei.hwnd = NULL;
+        //sei.lpVerb = L"runas"; // Request elevation
+        sei.lpFile = L"explorer.exe";
+        sei.lpParameters = nullptr;
+
+        // Compose command line: "<uninstaller_path>" /S /clearreg
+        std::wstring params = L"\"";
+        params += buffer;
+        params += L"\"";
+        params += L" /S /clearreg"; // silent uninstall and clear registry entries
+        sei.lpParameters = params.c_str();
+
+        sei.nShow = SW_HIDE;
+
+        if (!ShellExecuteExW(&sei))
+        {
+            LL_WARNS("AppInit") << "Failed to launch NSIS uninstaller, error code: " << GetLastError() << LL_ENDL;
+        }
+    });
+#endif
+}
+
 /**
 * Check if user is running a new version of the viewer.
 * Display the Release Notes if it's not overriden by the "UpdaterShowReleaseNotes" setting.

indra/newview/llvelopack.cpp

@@ -28,6 +28,7 @@
 
 #include "llviewerprecompiledheaders.h"
 #include "llvelopack.h"
+#include "llstring.h"
 
 #include "Velopack.h"
 
@@ -37,6 +38,7 @@
 #include <shobjidl.h>
 #include <shlwapi.h>
 #include <objbase.h>
+#include <filesystem>
 
 #pragma comment(lib, "shlwapi.lib")
 #pragma comment(lib, "ole32.lib")
@@ -175,6 +177,81 @@ static void register_protocol_handler(const std::wstring& protocol,
     }
 }
 
+bool get_nsis_uninstaller_path(wchar_t* path_buffer, DWORD bufSize)
+{
+    // Test for presense of NSIS viewer registration, then
+    // attempt to read uninstall info
+    std::wstring app_name_oneword = get_app_name_oneword();
+    std::wstring uninstall_key_path = L"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\" + app_name_oneword;
+    HKEY hkey;
+    LONG result = RegOpenKeyExW(HKEY_LOCAL_MACHINE, uninstall_key_path.c_str(), 0, KEY_READ, &hkey);
+    if (result != ERROR_SUCCESS)
+    {
+        return false;
+    }
+
+    // Read DisplayVersion
+    wchar_t version_buf[64] = { 0 };
+    DWORD version_buf_size = sizeof(version_buf);
+    DWORD type = 0;
+    LONG ver_rv = RegGetValueW(hkey, nullptr, L"DisplayVersion", RRF_RT_REG_SZ, &type, version_buf, &version_buf_size);
+    // Compare versions if both are available
+    if (ver_rv == ERROR_SUCCESS)
+    {
+        // Get current version as UTF-8 string, convert to wstring
+        std::string current_version_str = velopack_get_current_version();
+        std::wstring current_version_w;
+        if (!current_version_str.empty())
+        {
+            int wlen = MultiByteToWideChar(CP_UTF8, 0, current_version_str.c_str(), -1, nullptr, 0);
+            if (wlen > 0)
+            {
+                current_version_w.resize(wlen - 1);
+                MultiByteToWideChar(CP_UTF8, 0, current_version_str.c_str(), -1, &current_version_w[0], wlen);
+            }
+        }
+        // If NSIS version is newer, skip removal
+        // todo: for testing purposes this ignores missing version,
+        // should skip if current version is uknown
+        if (!current_version_w.empty() && wcscmp(version_buf, current_version_w.c_str()) > 0)
+        {
+            RegCloseKey(hkey);
+            return false;
+        }
+    }
+
+    LONG rv = RegGetValueW(hkey, nullptr, L"UninstallString", RRF_RT_REG_SZ, &type, path_buffer, &bufSize);
+    RegCloseKey(hkey);
+    if (rv != ERROR_SUCCESS)
+    {
+        return false;
+    }
+    size_t len = wcslen(path_buffer);
+    if (len > 0)
+    {
+        if (path_buffer[0] == L'\"')
+        {
+            // Shift all characters left by one, including the null terminator
+            memmove(path_buffer, path_buffer + 1, (len) * sizeof(wchar_t));
+        }
+
+        wchar_t* pos = wcsstr(path_buffer, L"uninst.exe");
+        if (pos)
+        {
+            pos[wcslen(L"uninst.exe")] = L'\0';
+        }
+    }
+    std::error_code ec;
+    std::filesystem::path path(path_buffer);
+    if (!std::filesystem::exists(path, ec))
+    {
+        // If ec, assume that it's there?
+        return false;
+    }
+
+    return true;
+}
+
 static void unregister_protocol_handler(const std::wstring& protocol)
 {
     std::wstring key_path = L"SOFTWARE\\Classes\\" + protocol;
@@ -206,6 +283,18 @@ static void register_uninstall_info(const std::wstring& install_dir,
         RegSetValueExW(hkey, L"DisplayIcon", 0, REG_SZ,
                       (BYTE*)exe_path.c_str(), (DWORD)((exe_path.size() + 1) * sizeof(wchar_t)));
 
+        std::wstring link_url = L"https://support.secondlife.com/contact-support/";
+        RegSetValueExW(hkey, L"HelpLink", 0, REG_SZ,
+            (BYTE*)link_url.c_str(), (DWORD)((link_url.size() + 1) * sizeof(wchar_t)));
+
+        link_url = L"https://secondlife.com/whatis/";
+        RegSetValueExW(hkey, L"URLInfoAbout", 0, REG_SZ,
+            (BYTE*)link_url.c_str(), (DWORD)((link_url.size() + 1) * sizeof(wchar_t)));
+
+        link_url = L"http://secondlife.com/support/downloads/";
+        RegSetValueExW(hkey, L"URLUpdateInfo", 0, REG_SZ,
+            (BYTE*)link_url.c_str(), (DWORD)((link_url.size() + 1) * sizeof(wchar_t)));
+
         DWORD no_modify = 1;
         RegSetValueExW(hkey, L"NoModify", 0, REG_DWORD, (BYTE*)&no_modify, sizeof(DWORD));
         RegSetValueExW(hkey, L"NoRepair", 0, REG_DWORD, (BYTE*)&no_modify, sizeof(DWORD));
@@ -251,6 +340,8 @@ static void remove_shortcuts(const std::wstring& app_name)
 
 static void on_after_install(void* user_data, const char* app_version)
 {
+    LLVelopack::sAfterInstall = true;
+
     std::wstring install_dir = get_install_dir();
     std::wstring app_name = get_app_name();
     std::wstring exe_path = install_dir + L"\\" + VIEWER_EXE_NAME;

indra/newview/llvelopack.h

@@ -32,6 +32,11 @@
 #include <string>
 #include <functional>
 
+namespace LLVelopack
+{
+    static bool sAfterInstall = false;
+}
+
 bool velopack_initialize();
 void velopack_check_for_updates();
 std::string velopack_get_current_version();
@@ -40,6 +45,10 @@ void velopack_apply_pending_update(bool restart = true);
 void velopack_set_update_url(const std::string& url);
 void velopack_set_progress_callback(std::function<void(int)> callback);
 
+#if LL_WINDOWS
+bool get_nsis_uninstaller_path(wchar_t* path_buffer, DWORD bufSize);
+#endif
+
 #endif // LL_VELOPACK
 #endif
 // EOF

indra/newview/skins/default/xui/en/notifications.xml

@@ -200,6 +200,18 @@ No tutorial is currently available.
      yestext="OK"/>
   </notification>
 
+  <notification
+   icon="alertmodal.tga"
+   name="PromptRemoveNsisInstallation"
+   type="alertmodal">
+   [APP_NAME] found installation from an older version. Do you want to uninstall previous version? Uninstaller might request access to files on disk.
+    <tag>confirm</tag>
+    <usetemplate
+     name="okcancelbuttons"
+     notext="Cancel"
+     yestext="Uninstall"/>
+  </notification>
+
   <notification
    icon="alertmodal.tga"
    name="LoginFailedNoNetwork"