Skip to content

Zap-Advanced unit-tests fail: cannot import name 'soft_unicode' from 'markupsafe' #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RamiSouai opened this issue Feb 21, 2022 · 0 comments · Fixed by #992
Closed

Zap-Advanced unit-tests fail: cannot import name 'soft_unicode' from 'markupsafe' #990

RamiSouai opened this issue Feb 21, 2022 · 0 comments · Fixed by #992
Labels
bug Bugs ci Changes to the continuous integration setup dependencies Pull requests that update a dependency file python Issues based on python implementations scanner Implement or update a security scanner testing Improvements or additions regarding the test setup

Comments

@RamiSouai
Copy link
Member

🐞 Bug report

Describe the bug

Zap-Advanced unit tests fail in the pipline and throw the following error:

ImportError: cannot import name 'soft_unicode' from 'markupsafe'

Steps To Reproduce

Tigger the CI pipeline thourgh a push to the secureCodeBox repository

Expected behavior

The Zap-Advanced unit tests should run successfully

Screenshots / Logs

https://github.com/secureCodeBox/secureCodeBox/runs/5255972111?check_suite_focus=true

Additional context

The zap-advanced scanner depends on HiYaPyCo, which depends on jinja2, which depends on markupsafe. The 17/02/2022 release of markupsafe depricated the soft_unicode API. Jinja2 has aready adressed this issue. But HiYaPyCo hasn't had a realease since March of 2020
@RamiSouai RamiSouai added bug Bugs ci Changes to the continuous integration setup dependencies Pull requests that update a dependency file python Issues based on python implementations scanner Implement or update a security scanner testing Improvements or additions regarding the test setup labels Feb 21, 2022
@rseedorff rseedorff linked a pull request Feb 22, 2022 that will close this issue
Added requirement to MarkupSafe to version 2.0.1 #992
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bugs ci Changes to the continuous integration setup dependencies Pull requests that update a dependency file python Issues based on python implementations scanner Implement or update a security scanner testing Improvements or additions regarding the test setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added requirement to MarkupSafe to version 2.0.1 secureCodeBox/secureCodeBox
1 participant
@RamiSouai