Skip to content

Commit 319e4d7

Browse files
committed
[build] make sure task arguments are Arrays
1 parent eb38753 commit 319e4d7

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

Rakefile

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ namespace :node do
525525

526526
desc 'Build Node npm package'
527527
task :build, [:args] do |_task, arguments|
528-
args = arguments[:args] || []
528+
args = Array(arguments[:args]) || []
529529
Bazel.execute('build', args, '//javascript/node/selenium-webdriver')
530530
end
531531

@@ -573,14 +573,14 @@ end
573573
namespace :py do
574574
desc 'Build Python wheel and sdist with optional arguments'
575575
task :build, [:args] do |_task, arguments|
576-
args = arguments[:args] || []
576+
args = Array(arguments[:args]) || []
577577
Bazel.execute('build', args, '//py:selenium-wheel')
578578
Bazel.execute('build', args, '//py:selenium-sdist')
579579
end
580580

581581
desc 'Release Python wheel and sdist to pypi'
582582
task :release, [:args] do |_task, arguments|
583-
args = arguments[:args] || ['--stamp']
583+
args = Array(arguments[:args]) || ['--stamp']
584584
Bazel.execute('run', args, '//py:selenium-release')
585585
end
586586

@@ -711,7 +711,7 @@ end
711711
namespace :rb do
712712
desc 'Generate Ruby gems'
713713
task :build, [:args] do |_task, arguments|
714-
args = arguments[:args] || []
714+
args = Array(arguments[:args]) || []
715715
Bazel.execute('build', args, '//rb:selenium-webdriver')
716716
Bazel.execute('build', args, '//rb:selenium-devtools')
717717
end
@@ -725,7 +725,7 @@ namespace :rb do
725725

726726
desc 'Push Ruby gems to rubygems'
727727
task :release, [:args] do |_task, arguments|
728-
args = arguments[:args] || ['--stamp']
728+
args = Array(arguments[:args]) || ['--stamp']
729729
Bazel.execute('run', args, '//rb:selenium-webdriver-release')
730730
Bazel.execute('run', args, '//rb:selenium-devtools-release')
731731
end
@@ -776,13 +776,13 @@ end
776776
namespace :dotnet do
777777
desc 'Build nupkg files'
778778
task :build, [:args] do |_task, arguments|
779-
args = arguments[:args] || []
779+
args = Array(arguments[:args]) || []
780780
Bazel.execute('build', args, '//dotnet:all')
781781
end
782782

783783
desc 'Create zipped assets for .NET for uploading to GitHub'
784784
task :zip_assets, [:args] do |_task, arguments|
785-
args = arguments[:args] || ['--stamp']
785+
args = Array(arguments[:args]) || ['--stamp']
786786
Rake::Task['dotnet:build'].invoke(args)
787787
mkdir_p 'build/dist'
788788
FileUtils.rm_f('build/dist/*dotnet*')
@@ -795,7 +795,7 @@ namespace :dotnet do
795795

796796
desc 'Upload nupkg files to Nuget'
797797
task :release, [:args] do |_task, arguments|
798-
args = arguments[:args] || ['--stamp']
798+
args = Array(arguments[:args]) || ['--stamp']
799799
Rake::Task['dotnet:build'].invoke(args)
800800
Rake::Task['dotnet:zip_assets'].invoke(args)
801801

@@ -856,26 +856,26 @@ end
856856
namespace :java do
857857
desc 'Build Java Client Jars'
858858
task :build, [:args] do |_task, arguments|
859-
args = arguments[:args] || []
859+
args = Array(arguments[:args]) || []
860860
Bazel.execute('build', args, '//java/src/org/openqa/selenium:client-combined')
861861
end
862862

863863
desc 'Build Grid Jar'
864864
task :grid, [:args] do |_task, arguments|
865-
args = arguments[:args] || []
865+
args = Array(arguments[:args]) || []
866866
Bazel.execute('build', args, '//java/src/org/openqa/selenium/grid:grid')
867867
end
868868

869869
desc 'Package Java bindings and grid into releasable packages'
870870
task :package, [:args] do |_task, arguments|
871-
args = arguments[:args] || []
871+
args = Array(arguments[:args]) || []
872872
Rake::Task['java:build'].invoke(args)
873873
Rake::Task['java-release-zip'].invoke
874874
end
875875

876876
desc 'Deploy all jars to Maven'
877877
task :release, [:args] do |_task, arguments|
878-
args = arguments[:args] || ['--stamp']
878+
args = Array(arguments[:args]) || ['--stamp']
879879
Rake::Task['java:package'].invoke(args)
880880
Rake::Task['publish-maven'].invoke
881881
end
@@ -951,7 +951,7 @@ end
951951
namespace :rust do
952952
desc 'Build Selenium Manager'
953953
task :build, [:args] do |_task, arguments|
954-
args = arguments[:args] || []
954+
args = Array(arguments[:args]) || []
955955
Bazel.execute('build', args, '//rust:selenium-manager')
956956
end
957957

@@ -1006,7 +1006,7 @@ namespace :all do
10061006

10071007
desc 'Build all artifacts for all language bindings'
10081008
task :build, [:args] do |_task, arguments|
1009-
args = arguments[:args] || []
1009+
args = Array(arguments[:args]) || []
10101010
Rake::Task['java:build'].invoke(args)
10111011
Rake::Task['py:build'].invoke(args)
10121012
Rake::Task['rb:build'].invoke(args)
@@ -1020,7 +1020,7 @@ namespace :all do
10201020
tag = @git.add_tag("selenium-#{java_version}")
10211021
@git.push('origin', tag.name)
10221022

1023-
args = arguments[:args] || ['--stamp']
1023+
args = Array(arguments[:args]) || ['--stamp']
10241024
Rake::Task['java:release'].invoke(args)
10251025
Rake::Task['py:release'].invoke(args)
10261026
Rake::Task['rb:release'].invoke(args)
@@ -1049,15 +1049,15 @@ namespace :all do
10491049
end
10501050

10511051
desc 'Update everything in preparation for a release'
1052-
task :prepare, [:channel] do |_task, arguments|
1053-
args = arguments[:channel] ? ['--', "--chrome_channel=#{arguments[:channel].capitalize}"] : []
1054-
Bazel.execute('run', args, '//scripts:update_cdp')
1055-
Bazel.execute('run', args, '//scripts:pinned_browsers')
1056-
Bazel.execute('run', args, '//scripts:selenium_manager')
1057-
Rake::Task['java:update'].invoke
1058-
Rake::Task['authors'].invoke
1059-
Rake::Task['copyright:update'].invoke
1060-
end
1052+
task :prepare, [:channel] do |_task, arguments|
1053+
args = Array(arguments[:channel]) ? ['--', "--chrome_channel=#{arguments[:channel].capitalize}"] : []
1054+
Bazel.execute('run', args, '//scripts:update_cdp')
1055+
Bazel.execute('run', args, '//scripts:pinned_browsers')
1056+
Bazel.execute('run', args, '//scripts:selenium_manager')
1057+
Rake::Task['java:update'].invoke
1058+
Rake::Task['authors'].invoke
1059+
Rake::Task['copyright:update'].invoke
1060+
end
10611061

10621062
desc 'Update all versions'
10631063
task :version, [:version] do |_task, arguments|

0 commit comments

Comments
 (0)