Skip to content

Missing success comments on issues #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgreinacher opened this issue May 8, 2024 · 1 comment · Fixed by #829
Closed

Missing success comments on issues #827

fgreinacher opened this issue May 8, 2024 · 1 comment · Fixed by #829

Comments

@fgreinacher
Copy link
Contributor

fgreinacher commented May 8, 2024

I have just noticed that @semantic-release/github does not comment on resolved issues. This has worked at some point in the past but seems to be broken for quite some time.

My initial suspicion is that we do not pass the correct GitHub URL to issue-parser at https://github.com/semantic-release/github/blob/master/lib/success.js#L56 and therefore cannot determine the correct org/repo tuple at https://github.com/semantic-release/github/blob/master/lib/success.js#L116.

Examples:

Copy link

🎉 This issue has been resolved in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant