Skip to content

Commit 9eed0e8

Browse files
committed
release the dimension check
1 parent 3b14540 commit 9eed0e8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

ddf_utils/chef/procedure.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -533,10 +533,8 @@ def window(ingredient: BaseIngredient, result, **options) -> ProcedureResult:
533533
# There is a bug when running rolling on with groupby in pandas.
534534
# see https://github.com/pandas-dev/pandas/issues/13966
535535
# We will implement this later when we found work around or it's fixed
536-
# for now, the we assume only 2 dimensions in the dataframe and don't
537-
# use the `on` parameter in rolling.
538-
if len(df.index.names) > 2:
539-
raise NotImplementedError('Not supporting more than 2 dimensions for now.')
536+
# for now, we don't use the `on` parameter in rolling.
537+
# FIXME: add back the `on` parameter.
540538
newdata[k] = (df.groupby(level=levels, group_keys=False)
541539
.rolling(window=size, min_periods=min_periods, center=center)
542540
.agg(func).reset_index().dropna())

0 commit comments

Comments
 (0)