Skip to content

Commit 8104f02

Browse files
serchershnooshnoo
andcommitted
test: skip test-child-process-stdio-reuse-readable-stdio on
It is flaky due to the same cause of test-child-process-pipe-dataflow being flaky - cygwin quirks - so skip it on Windows too. Drive-by: remove the skip mark of test-child-process-pipe-dataflow in the status file and directly skip it in the test with a comment. PR-URL: nodejs/node#49621 Backport-PR-URL: nodejs/node#51132 Co-authored-by: Artur Yapparov <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
1 parent ecf3055 commit 8104f02

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

graal-nodejs/test/parallel/parallel.status

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,6 @@ test-tls-passphrase: FAIL
259259
test-crypto-keygen: PASS,FLAKY
260260
# https://github.com/nodejs/node/issues/41201
261261
test-fs-rmdir-recursive: PASS, FLAKY
262-
# https://github.com/nodejs/node/issues/48300
263-
test-child-process-pipe-dataflow: PASS, FLAKY
264-
test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY
265262
# https://github.com/nodejs/node/issues/49985
266263
test-runner-watch-mode: PASS, FLAKY
267264
# https://github.com/nodejs/node/issues/50295

graal-nodejs/test/parallel/test-child-process-pipe-dataflow.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
4+
if (common.isWindows) {
5+
// https://github.com/nodejs/node/issues/48300
6+
common.skip('Does not work with cygwin quirks on Windows');
7+
}
8+
39
const assert = require('assert');
410
const path = require('path');
511
const fs = require('fs');

graal-nodejs/test/parallel/test-child-process-stdio-reuse-readable-stdio.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
4+
if (common.isWindows) {
5+
// https://github.com/nodejs/node/issues/48300
6+
common.skip('Does not work with cygwin quirks on Windows');
7+
}
8+
39
const assert = require('assert');
410
const { spawn } = require('child_process');
511

0 commit comments

Comments
 (0)