Skip to content

Implement valuable::Valuable on serde_json::Value as a feature flag #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vrajs16 opened this issue Apr 26, 2025 · 0 comments · May be fixed by #1256
Open

Implement valuable::Valuable on serde_json::Value as a feature flag #1255

Vrajs16 opened this issue Apr 26, 2025 · 0 comments · May be fixed by #1256

Comments

@Vrajs16
Copy link

Vrajs16 commented Apr 26, 2025

I am wondering if we can implement this trait from the valuable crate on serde_json::Value.

This would be really helpful with tracing and logging the serde_json::Value as a structured json.

I found this pr from 4 years ago in the valuable crate but never been merged and as the description says it should be included in this crate.

If this is something that could be merged, I wouldn't mind working on this.

Thanks!

@Vrajs16 Vrajs16 linked a pull request Apr 26, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant