fix: unpublish when the node no longer exists

When a VM is removed along with its block devices, we need to complete the unpublish process.

Signed-off-by: Serge Logvinov <[email protected]>

Author: sergelogvinov

pkg/csi/controller.go

@@ -585,6 +585,12 @@ func (d *ControllerService) ControllerUnpublishVolume(ctx context.Context, reque
 
 	vmr, err := d.getVMRefbyNodeID(ctx, cl, nodeID)
 	if err != nil {
+		if strings.Contains(err.Error(), "not found") {
+			klog.V(3).InfoS("ControllerUnpublishVolume: node does not exist", "volumeID", vol.VolumeID(), "nodeID", nodeID)
+
+			return &csi.ControllerUnpublishVolumeResponse{}, nil
+		}
+
 		return nil, err
 	}
 

pkg/csi/controller_test.go

@@ -1104,7 +1104,6 @@ func (ts *configuredTestSuite) TestControllerUnpublishVolumeError() {
 				NodeId:   "cluster-1-node-3",
 				VolumeId: "cluster-1/pve-1/local-lvm/vm-9999-pvc-123",
 			},
-			expectedError: status.Error(codes.InvalidArgument, "nodes \"cluster-1-node-3\" not found"),
 		},
 		{
 			msg: "WrongPVZone",