Skip to content

Should autocreate schema when autoCreateSqlTable is true #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdarrigo opened this issue Jan 17, 2018 · 2 comments · Fixed by #166
Closed

Should autocreate schema when autoCreateSqlTable is true #107

cdarrigo opened this issue Jan 17, 2018 · 2 comments · Fixed by #166
Assignees

Comments

@cdarrigo
Copy link

When auto provisioning the table, and specifying a schema, the schema should be automatically created. The current code base fails to autocreate the schema, and if it does not exist, the table fails to get created, and the sink will not log as intended.

Adding this auto-create functionality for the schema prevents the need for any manual intervention when deploying to a new environment.

@nblumhardt
Copy link
Contributor

Hi @cdarrigo - what is the failure when the code tries to auto-create? Thanks!

@MV10 MV10 added enhancement up-for-grabs This issue waits for a contributor to fix it. labels Sep 9, 2018
@MV10
Copy link
Contributor

MV10 commented Sep 9, 2018

Presumably the message would be the SQL error "The specified schema name "xxxxx" either does not exist or you do not have permission to use it." But rather than responding to the error, the fix would be to check whether the schema exists and call CREATE SCHEMA if it does not.

@cdarrigo Do you see the need for any considerations beyond that?

@MV10 MV10 removed the up-for-grabs This issue waits for a contributor to fix it. label Oct 10, 2018
@MV10 MV10 self-assigned this Oct 10, 2018
@MV10 MV10 closed this as completed in #166 Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants