Skip to content

Enable user to control the column sizes #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JocaPC opened this issue Sep 17, 2018 · 2 comments · Fixed by #166
Closed

Enable user to control the column sizes #146

JocaPC opened this issue Sep 17, 2018 · 2 comments · Fixed by #166
Assignees

Comments

@JocaPC
Copy link

JocaPC commented Sep 17, 2018

Maybe it would be useful to introduce fields like ColumnOptions.Message.Size and ColumnOptions.Level.Size that would enable users to control column size. Also, it might be more flexible to have Id.Size instead of Id.Bigint (but I guess that everyone will use either int or bigint so this is fine.)

Also, why is Level defined as nvarchar(128) instead of varchar(12), which should be sufficient to store "Information" level? Query Optimizer looks at the statistic about the number of rows and size of columns to calculate memory grant that should be assigned to query. Adding too big types might cause that queries on log table eat too much memory that they don't use, and starve other queries.

@MV10
Copy link
Contributor

MV10 commented Sep 17, 2018

In general, I don't like the way this sink has one group of properties for the standard columns and a completely different group of properties for custom columns (which do have DataLength), but that's probably one of those things that will never change now for compatibility reasons...

@MV10 MV10 self-assigned this Oct 9, 2018
@MV10
Copy link
Contributor

MV10 commented Oct 9, 2018

Currently overhauling sink configuration -- remaining backwards compatible but marking some things obsolete, Standard Columns and custom columns will be configured in the same way, and controlling the size of everything is one small piece of the puzzle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants