Skip to content

Use System.Data.SqlDbType enums for column types instead of .NET Types #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MV10 opened this issue Oct 7, 2018 · 3 comments · Fixed by #166
Closed

Use System.Data.SqlDbType enums for column types instead of .NET Types #155

MV10 opened this issue Oct 7, 2018 · 3 comments · Fixed by #166
Assignees
@MV10
Labels
enhancement

Comments

@MV10
Copy link
Contributor

MV10 commented Oct 7, 2018

The CreateDataTable method should configure the DataColumn.DataType properties using System.Data.SqlTypes rather than .NET CLR Types, which involves some ambiguity and assumptions that serve no useful purpose.

The README documentation should also reflect this preference in the section showing how to add custom property columns.

Could probably be implemented alongside feature request #130.
@MV10 MV10 added enhancement up-for-grabs This issue waits for a contributor to fix it. labels Oct 7, 2018
@MV10
Copy link
Contributor Author

MV10 commented Oct 7, 2018

Upon further review, SqlTypes is surprisingly limited compared to what's actually available in SQL.

@MV10 MV10 closed this as completed Oct 7, 2018
@MV10 MV10 removed the up-for-grabs This issue waits for a contributor to fix it. label Oct 10, 2018
@MV10 MV10 self-assigned this Oct 10, 2018
@MV10 MV10 changed the title Use System.Data.SqlTypes for column types instead of .NET Types Use System.Data.SqlDbType enums for column types instead of .NET Types Oct 10, 2018
@MV10
Copy link
Contributor Author

MV10 commented Oct 10, 2018

The next PR will use System.Data.SqlDbType enums which will allow us to accurately represent all (well, most) of the correct SQL Server column types.

@MV10 MV10 reopened this Oct 10, 2018
@MV10 MV10 mentioned this issue Oct 13, 2018
Merged
@MV10 MV10 closed this as completed in #166 Oct 16, 2018
@douglasg14b
Copy link

When did this change? ColumnOptions now requires a Type for the DataType.... Which is pretty ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MV10 MV10

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config revisions, all tests passing
2 participants
@MV10 @douglasg14b